Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758167AbcKCQtQ (ORCPT ); Thu, 3 Nov 2016 12:49:16 -0400 Received: from vern.gendns.com ([206.190.152.46]:38986 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbcKCQtO (ORCPT ); Thu, 3 Nov 2016 12:49:14 -0400 Subject: Re: [PATCH v2 0/3] davinci: ohci: fix usb ohci device name To: Axel Haslam , khilman@kernel.org, nsekhar@ti.com, gregkh@linuxfoundation.org, kishon@ti.com References: <20161103160308.29588-1-ahaslam@baylibre.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: David Lechner Message-ID: Date: Thu, 3 Nov 2016 11:49:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161103160308.29588-1-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 42 On 11/03/2016 11:03 AM, Axel Haslam wrote: > The usb ohci clock match is not working because the usb clock > is registered as "ohci" instead of "ohci.0" > > But since there is only a single ohci instance, lets pass -1 to > the platform data id parameter and avoid the extra ".0" matching. > > while we are fixing this, rename the driver from "ohci" to > "ohci-da8xx" which is less generic and consistent with other > usb drivers. > > changes form v1 -> v2 > *Reword commit messages (David Lechner) > > Because of the recently accepted patches on the ARM-davinci side, > This patch series is based on: > branch: /v4.10/soc of the linux-davinci tree. > > It Depends on two accepted usb patches missing on that branch: > 6c21caa USB: OHCI: make ohci-da8xx a separate driver (in next-usb) > 6110c42 usb: ohci-da8xx: Remove code that references mach (in linux-next) > > A branch with both patches applied + this series can be found here: > https://github.com/axelhaslamx/linux-axel/commits/ti-davinci-ohci-rename > > > Axel Haslam (3): > ARM: davinci: da8xx: Fix ohci device name > phy: da8xx-usb: rename the ohci device to ohci-da8xx > usb: ohci-da8xx: rename driver to ohci-da8xx > > arch/arm/mach-davinci/da830.c | 2 +- > arch/arm/mach-davinci/da850.c | 2 +- > arch/arm/mach-davinci/da8xx-dt.c | 2 +- > arch/arm/mach-davinci/usb-da8xx.c | 4 ++-- > drivers/phy/phy-da8xx-usb.c | 5 +++-- > drivers/usb/host/ohci-da8xx.c | 2 +- > 6 files changed, 9 insertions(+), 8 deletions(-) > Thanks for making the changes. The commit messages make better sense to me now. :-)