Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758725AbcKCQvW (ORCPT ); Thu, 3 Nov 2016 12:51:22 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:33161 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758076AbcKCQvU (ORCPT ); Thu, 3 Nov 2016 12:51:20 -0400 Subject: Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx To: Axel Haslam , , , , References: <20161102124435.31777-1-ahaslam@baylibre.com> <20161102124435.31777-3-ahaslam@baylibre.com> CC: , , From: Kishon Vijay Abraham I Message-ID: Date: Thu, 3 Nov 2016 22:20:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161102124435.31777-3-ahaslam@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 39 On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: > There is only one ohci on the da8xx series of chips, > so remove the ".0" when creating the phy. Also add > the "-da8xx" postfix to be consistent across davinci > usb drivers. > > Signed-off-by: Axel Haslam Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/phy-da8xx-usb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/phy/phy-da8xx-usb.c > index 32ae78c..c85fb0b 100644 > --- a/drivers/phy/phy-da8xx-usb.c > +++ b/drivers/phy/phy-da8xx-usb.c > @@ -198,7 +198,8 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev) > } else { > int ret; > > - ret = phy_create_lookup(d_phy->usb11_phy, "usb-phy", "ohci.0"); > + ret = phy_create_lookup(d_phy->usb11_phy, "usb-phy", > + "ohci-da8xx"); > if (ret) > dev_warn(dev, "Failed to create usb11 phy lookup\n"); > ret = phy_create_lookup(d_phy->usb20_phy, "usb-phy", > @@ -216,7 +217,7 @@ static int da8xx_usb_phy_remove(struct platform_device *pdev) > > if (!pdev->dev.of_node) { > phy_remove_lookup(d_phy->usb20_phy, "usb-phy", "musb-da8xx"); > - phy_remove_lookup(d_phy->usb11_phy, "usb-phy", "ohci.0"); > + phy_remove_lookup(d_phy->usb11_phy, "usb-phy", "ohci-da8xx"); > } > > return 0; >