Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758952AbcKCRBH (ORCPT ); Thu, 3 Nov 2016 13:01:07 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38248 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756850AbcKCRBG (ORCPT ); Thu, 3 Nov 2016 13:01:06 -0400 Date: Thu, 3 Nov 2016 18:00:56 +0100 From: Daniel Lezcano To: Vineet Gupta Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, Noam Camus , Alexey.Brodkin@synopsys.com Subject: Re: [PATCH 1/9] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists ... Message-ID: <20161103170056.GB1859@mai> References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-2-git-send-email-vgupta@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477954096-770-2-git-send-email-vgupta@synopsys.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 51 On Mon, Oct 31, 2016 at 03:48:08PM -0700, Vineet Gupta wrote: > ... don't rely on cpuinfo populated in arc boot code. This paves wat for > moving this code in drivers/clocksource/ > > Signed-off-by: Vineet Gupta > --- > arch/arc/kernel/time.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c > index f927b8dc6edd..a2db010cde18 100644 > --- a/arch/arc/kernel/time.c > +++ b/arch/arc/kernel/time.c > @@ -118,10 +118,11 @@ static struct clocksource arc_counter_gfrc = { > > static int __init arc_cs_setup_gfrc(struct device_node *node) > { > - int exists = cpuinfo_arc700[0].extn.gfrc; > + struct mcip_bcr mp; > int ret; > > - if (WARN(!exists, "Global-64-bit-Ctr clocksource not detected")) > + READ_BCR(ARC_REG_MCIP_BCR, mp); > + if (WARN(!mp.gfrc, "Global-64-bit-Ctr clocksource not detected")) Take the opportunity to replace this WARN by a pr_err. > return -ENXIO; > > ret = arc_get_timer_clk(node); > @@ -174,10 +175,11 @@ static struct clocksource arc_counter_rtc = { > > static int __init arc_cs_setup_rtc(struct device_node *node) > { > - int exists = cpuinfo_arc700[smp_processor_id()].extn.rtc; > + struct bcr_timer timer; > int ret; > > - if (WARN(!exists, "Local-64-bit-Ctr clocksource not detected")) > + READ_BCR(ARC_REG_TIMERS_BCR, timer); > + if (WARN(!timer.rtc, "Local-64-bit-Ctr clocksource not detected")) > return -ENXIO;o Ditto and ^^ So the READ_BCR() is only there to check the timer is physically present ? > /* Local to CPU hence not usable in SMP */ > -- > 2.7.4 >