Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758892AbcKCRDH (ORCPT ); Thu, 3 Nov 2016 13:03:07 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37961 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757964AbcKCRDG (ORCPT ); Thu, 3 Nov 2016 13:03:06 -0400 Date: Thu, 3 Nov 2016 18:02:56 +0100 From: Daniel Lezcano To: Vineet Gupta Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, Noam Camus , Alexey.Brodkin@synopsys.com Subject: Re: [PATCH 2/9] ARC: timer: rtc: implement read loop in "C" vs. inline asm Message-ID: <20161103170256.GC1859@mai> References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-3-git-send-email-vgupta@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477954096-770-3-git-send-email-vgupta@synopsys.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 39 On Mon, Oct 31, 2016 at 03:48:09PM -0700, Vineet Gupta wrote: > To allow for easy movement into drivers/clocksource > > Signed-off-by: Vineet Gupta > --- > arch/arc/kernel/time.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c > index a2db010cde18..2c51e3cafad0 100644 > --- a/arch/arc/kernel/time.c > +++ b/arch/arc/kernel/time.c > @@ -153,14 +153,11 @@ static cycle_t arc_read_rtc(struct clocksource *cs) > cycle_t full; > } stamp; > > - > - __asm__ __volatile( > - "1: \n" > - " lr %0, [AUX_RTC_LOW] \n" > - " lr %1, [AUX_RTC_HIGH] \n" > - " lr %2, [AUX_RTC_CTRL] \n" > - " bbit0.nt %2, 31, 1b \n" > - : "=r" (stamp.low), "=r" (stamp.high), "=r" (status)); > + do { > + stamp.low = read_aux_reg(AUX_RTC_LOW); > + stamp.high = read_aux_reg(AUX_RTC_HIGH); > + status = read_aux_reg(AUX_RTC_CTRL); > + } while (!(status & 0x80000000UL)); Replace the literal 0x80000000UL by a macro. What is the 'status' for ? > return stamp.full; > } > -- > 2.7.4 >