Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933085AbcKCRra (ORCPT ); Thu, 3 Nov 2016 13:47:30 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:35629 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758403AbcKCRr3 (ORCPT ); Thu, 3 Nov 2016 13:47:29 -0400 Subject: Re: [PATCH 3/9] ARC: timer: gfrc: boot print alongside other timers To: Daniel Lezcano References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-4-git-send-email-vgupta@synopsys.com> <20161103170941.GD1859@mai> CC: , , , Noam Camus , Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: Date: Thu, 3 Nov 2016 10:47:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161103170941.GD1859@mai> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.44] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 41 On 11/03/2016 10:09 AM, Daniel Lezcano wrote: > On Mon, Oct 31, 2016 at 03:48:10PM -0700, Vineet Gupta wrote: >> Signed-off-by: Vineet Gupta > > Why not add a message in drivers/clocksource/clksrc-probe.c when a timer inits > successfully ? and then get rid of this code. At boot I have bunch of cod which prints all the major hardware blocks and thus would like to print it. We also print if a feature is present but not supported etc. So I like to keep all of that here. Also same code is used for /proc/cpuinfo. > >> --- >> arch/arc/kernel/setup.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c >> index 0385df77a697..595d06900061 100644 >> --- a/arch/arc/kernel/setup.c >> +++ b/arch/arc/kernel/setup.c >> @@ -234,11 +234,11 @@ static char *arc_cpu_mumbojumbo(int cpu_id, char *buf, int len) >> is_isa_arcompact() ? "ARCompact" : "ARCv2", >> IS_AVAIL1(cpu->isa.be, "[Big-Endian]")); >> >> - n += scnprintf(buf + n, len - n, "Timers\t\t: %s%s%s%s\nISA Extn\t: ", >> + n += scnprintf(buf + n, len - n, "Timers\t\t: %s%s%s%s%s%s\nISA Extn\t: ", >> IS_AVAIL1(cpu->extn.timer0, "Timer0 "), >> IS_AVAIL1(cpu->extn.timer1, "Timer1 "), >> - IS_AVAIL2(cpu->extn.rtc, "Local-64-bit-Ctr ", >> - CONFIG_ARC_HAS_RTC)); >> + IS_AVAIL2(cpu->extn.rtc, "RTC [UP 64-bit] ", CONFIG_ARC_HAS_RTC), >> + IS_AVAIL2(cpu->extn.gfrc, "GFRC [SMP 64-bit] ", CONFIG_ARC_HAS_GFRC)); >> >> n += i = scnprintf(buf + n, len - n, "%s%s%s%s%s", >> IS_AVAIL2(cpu->isa.atomic, "atomic ", CONFIG_ARC_HAS_LLSC), >> -- >> 2.7.4 >> >