Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759829AbcKCSLV (ORCPT ); Thu, 3 Nov 2016 14:11:21 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38326 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759598AbcKCSLU (ORCPT ); Thu, 3 Nov 2016 14:11:20 -0400 Date: Thu, 3 Nov 2016 19:11:12 +0100 From: Daniel Lezcano To: Vineet Gupta Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, Noam Camus , Alexey.Brodkin@synopsys.com Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver Message-ID: <20161103181112.GK1859@mai> References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-10-git-send-email-vgupta@synopsys.com> <20161101204257.GG1506@mai> <188a2912-3369-19a3-86af-cbb154ff7e44@synopsys.com> <20161102001925.GH1506@mai> <2dcf87ce-a278-8ef8-3c8e-3cf7124603c9@synopsys.com> <20161103165032.GA1859@mai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 24 On Thu, Nov 03, 2016 at 10:57:48AM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > >>>>> Because of the git mv you, diff didn't include bulk of driver code which would > >>>>>>> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. OK ? > >>>>> > >>>>> That means I will review and comment existing code. It is not a problem for me > >>>>> if you agree to do the changes. > >>> Sure, the whole point is to make things better as an outcome of review. I have no > >>> issues changing code provided we don't add major performance regressions. > >> > >> So just wondering if I could have some comments on the initial import of driver > >> before I send out a v2. > > > > Yeah, ok. Let me comment the other patches of the series and then you can send a V2. > > Thx for taking a quick look - this is a good start. How about the actual driver > itself, do you want to take a quick look there as well before v2 ? At the first glance, with your changes it is acceptable to be moved. Perhaps, you can have a look to remove the BIG_ENDIAN stuff in the clock read function.