Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759928AbcKCSYo (ORCPT ); Thu, 3 Nov 2016 14:24:44 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:57274 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757251AbcKCSYm (ORCPT ); Thu, 3 Nov 2016 14:24:42 -0400 X-ME-Helo: [127.0.0.1] X-ME-Date: Thu, 03 Nov 2016 19:24:40 +0100 X-ME-IP: 92.140.167.9 Subject: Re: [PATCH] btrfs: Remove some dead code To: Tobias Klauser References: <20161101102606.27006-1-christophe.jaillet@wanadoo.fr> <20161103124349.GA819@distanz.ch> Cc: clm@fb.com, jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel,gmane.comp.file-systems.btrfs,gmane.linux.kernel.janitors From: Christophe JAILLET Message-ID: Date: Thu, 3 Nov 2016 19:24:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161103124349.GA819@distanz.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 161102-1, 02/11/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 13 Le 03/11/2016 ? 13:43, Tobias Klauser a ?crit : > On 2016-11-01 at 11:26:06 +0100, Christophe JAILLET wrote: >> 'btrfs_iget()' can not return an error pointer, so this test can be >> removed. > This descrption does not match what the patch actually does. Shouldn't > it say "...can not return NULL, so this test can be removed."? > You are obviously correct. Cut'n'Paste error while sending other patches. I will send a V2 with an updated description. Thanks for the review. CJ