Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759987AbcKCSoW (ORCPT ); Thu, 3 Nov 2016 14:44:22 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:58402 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbcKCSoV (ORCPT ); Thu, 3 Nov 2016 14:44:21 -0400 Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver To: Daniel Lezcano References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-10-git-send-email-vgupta@synopsys.com> <20161101204257.GG1506@mai> <188a2912-3369-19a3-86af-cbb154ff7e44@synopsys.com> <20161102001925.GH1506@mai> <2dcf87ce-a278-8ef8-3c8e-3cf7124603c9@synopsys.com> <20161103165032.GA1859@mai> <20161103181112.GK1859@mai> CC: , , , Noam Camus , Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: Date: Thu, 3 Nov 2016 11:43:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161103181112.GK1859@mai> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.44] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 394 Lines: 8 On 11/03/2016 11:11 AM, Daniel Lezcano wrote: >> Thx for taking a quick look - this is a good start. How about the actual driver >> > itself, do you want to take a quick look there as well before v2 ? > At the first glance, with your changes it is acceptable to be moved. Perhaps, > you can have a look to remove the BIG_ENDIAN stuff in the clock read function. > OK addressed that as well !