Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760214AbcKCS4o (ORCPT ); Thu, 3 Nov 2016 14:56:44 -0400 Received: from mail.acc.umu.se ([130.239.18.156]:40838 "EHLO mail.acc.umu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758574AbcKCS4m (ORCPT ); Thu, 3 Nov 2016 14:56:42 -0400 Date: Thu, 3 Nov 2016 19:50:44 +0100 From: David Weinehall To: Lyude Cc: intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume Message-ID: <20161103185044.GG8202@suiko.acc.umu.se> Mail-Followup-To: Lyude , intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <1478187758-32740-1-git-send-email-lyude@redhat.com> <1478187758-32740-2-git-send-email-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478187758-32740-2-git-send-email-lyude@redhat.com> X-Editor: Vi Improved X-Accept-Language: Swedish, English X-GPG-Fingerprint: ED69 8CF5 6102 21B9 AFD1 9DB7 0B27 96FD 15DA A404 X-GPG-Key: http://www.acc.umu.se/~tao/files/pub_15daa404.gpg.asc User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 46 On Thu, Nov 03, 2016 at 11:42:37AM -0400, Lyude wrote: > Weine's investigation on benchmarking the suspend/resume process pointed > out a lot of the time in suspend/resume is being spent reprobing. While > the reprobing process is a lengthy one for good reason, we don't need to > hold up the entire suspend/resume process while we wait for it to > finish. Luckily as it turns out, we already trigger a full connector > reprobe in i915_hpd_poll_init_work(), so we can just ditch reprobing in > i915_drm_resume() entirely. > > This won't lead to less time spent resuming just yet since now the > bottleneck will be waiting for the mode_config lock in > drm_kms_helper_poll_enable(), since that will be held as long as > i915_hpd_poll_init_work() is reprobing all of the connectors. But we'll > address that in the next patch. > > Signed-off-by: Lyude > Cc: David Weinehall Tested-by: David Weinehall Reviewed-by: David Weinehall Testcase: analyze_suspend.py -config config/suspend-callgraph.cfg -filter i915 > --- > drivers/gpu/drm/i915/i915_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index bfb2efd..532cc0f 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1602,8 +1602,6 @@ static int i915_drm_resume(struct drm_device *dev) > * notifications. > * */ > intel_hpd_init(dev_priv); > - /* Config may have changed between suspend and resume */ > - drm_helper_hpd_irq_event(dev); > > intel_opregion_register(dev_priv); > > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx