Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759591AbcKCVQK (ORCPT ); Thu, 3 Nov 2016 17:16:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55872 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758853AbcKCVQJ (ORCPT ); Thu, 3 Nov 2016 17:16:09 -0400 Date: Thu, 3 Nov 2016 14:16:07 -0700 From: Andrew Morton To: Vitaly Wool Cc: Linux-MM , linux-kernel@vger.kernel.org, Dan Streetman Subject: Re: [PATH] z3fold: extend compaction function Message-Id: <20161103141607.855925f33be627dea9731eb3@linux-foundation.org> In-Reply-To: <20161103220428.984a8d09d0c9569e6bc6b8cc@gmail.com> References: <20161103220428.984a8d09d0c9569e6bc6b8cc@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 14 On Thu, 3 Nov 2016 22:04:28 +0100 Vitaly Wool wrote: > z3fold_compact_page() currently only handles the situation when > there's a single middle chunk within the z3fold page. However it > may be worth it to move middle chunk closer to either first or > last chunk, whichever is there, if the gap between them is big > enough. "may be worth it" is vague. Does the patch improve the driver or does it not? If it *does* improve the driver then in what way? *Why* is is "worth it"? > This patch adds the relevant code, using BIG_CHUNK_GAP define as > a threshold for middle chunk to be worth moving.