Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933523AbcKCXbX convert rfc822-to-8bit (ORCPT ); Thu, 3 Nov 2016 19:31:23 -0400 Received: from mga03.intel.com ([134.134.136.65]:41900 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933209AbcKCXbW (ORCPT ); Thu, 3 Nov 2016 19:31:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,440,1473145200"; d="scan'208";a="27182092" From: "Dilger, Andreas" To: Andrew Kanner CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , Alexander Viro , "bevans@cray.com" , "bhaktipriya96@gmail.com" , Lustre Development List , "devel@driverdev.osuosl.org" , "Linux Kernel Mailing List" Subject: Re: [PATCH v2] staging: lustre: fixed shadowed variable in socklnd_cb.c Thread-Topic: [PATCH v2] staging: lustre: fixed shadowed variable in socklnd_cb.c Thread-Index: AQHSNiUQovILpLT/yE+3XSsea5+9E6DIXdCA Date: Thu, 3 Nov 2016 23:31:18 +0000 Message-ID: <8314C33E-2E5A-4E25-8AE9-FDC5140E08FD@intel.com> References: <1478213386-13853-1-git-send-email-andrew.kanner@gmail.com> In-Reply-To: <1478213386-13853-1-git-send-email-andrew.kanner@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.128.107] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 33 On Nov 3, 2016, at 16:49, Andrew Kanner wrote: > > Removed redundant declaration of variable 'tx' in local scope > Fixed: sparse warning: > socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one > socklnd_cb.c:2435:25: originally declared here > > Signed-off-by: Andrew Kanner Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > index c1c6f60..f31f4a1 100644 > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > @@ -2473,8 +2473,8 @@ ksocknal_check_peer_timeouts(int idx) > * holding only shared lock > */ > if (!list_empty(&peer->ksnp_tx_queue)) { > - struct ksock_tx *tx = list_entry(peer->ksnp_tx_queue.next, > - struct ksock_tx, tx_list); > + tx = list_entry(peer->ksnp_tx_queue.next, > + struct ksock_tx, tx_list); > > if (cfs_time_aftereq(cfs_time_current(), > tx->tx_deadline)) { > -- > 2.1.4 >