Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757115AbcKDE2n (ORCPT ); Fri, 4 Nov 2016 00:28:43 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:37089 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813AbcKDE2l (ORCPT ); Fri, 4 Nov 2016 00:28:41 -0400 X-AuditID: cbfee61b-f796f6d000004092-86-581c0e766a6d Date: Fri, 04 Nov 2016 13:28:38 +0900 From: Andi Shyti To: Jacek Anaszewski Cc: Mauro Carvalho Chehab , Sean Young , Rob Herring , Mark Rutland , Richard Purdie , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver Message-id: <20161104042838.kwjv66ldun6g4hlv@gangnam.samsung> References: <20161102104010.26959-1-andi.shyti@samsung.com> <20161102104010.26959-6-andi.shyti@samsung.com> <70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com> <20161103101048.ofyoko4mkcypf44u@gangnam.samsung> <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> User-Agent: NeoMutt/20161014 (1.7.1) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t9jAd0yPpkIg917ZC3mHznHatF79Tmj xeVdc9gstr5Zx2jRs2Erq8XS6xeZLFY/q7Bo3XuE3WL3rqesFguffmdx4PJYM28No8emVZ1s HkveWHts6b/L7rFn/g9Wj74tqxg9Pm+SC2CPcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLI S8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGk6e32Qre81Qs7BBtYOzh6mLk5JAQ MJE4u/spI4QtJnHh3nq2LkYuDiGBpYwSy1+sZYFwPjJKbJ63lKmLkYODRUBVYvF2V5AGNgFN iabbP9hAbBEBfYmGhj5GkHpmga1MEpP33wBLCAskStw4e5QVxOYVsJU4PGcNO8TQ+0wSR/7f Z4NICEr8mHyPBcRmFtCSWL/zOBOELS3x6O8MdhCbU8Be4uzDBWA1ogIqErMuz2GZwCgwC0n7 LCTts5C0L2BkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRHJPPpHcwHt7lfohRgINR iYd3wzrpCCHWxLLiytxDjBIczEoivGzcMhFCvCmJlVWpRfnxRaU5qcWHGE2BITKRWUo0OR+Y LvJK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5NLUgtgulj4uCUamBs+JLw9oLcz0mP WL/2zozauuqb8fVXpU1KEraNByob7uXtv1yaHpJ9Kn/F4YDdRV7izh75QfluORFOf0wybJYe eyPhsVs7ddv75gMvUrv/PpZnyby+tUHr54zZ80N7hP0fsbcvE9iS98n4WR3ban9G66aPyz6a uUsUnb9a439P4ZWg3tS/vCJKLMUZiYZazEXFiQAofZkA3wIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 45 Hi Jacek, > > > Only DT bindings of LED class drivers should be placed in > > > Documentation/devicetree/bindings/leds. Please move it to the > > > media bindings. > > > > that's where I placed it first, but Rob asked me to put it in the > > LED directory and Cc the LED mailining list. > > > > That's the discussion of the version 2: > > > > https://lkml.org/lkml/2016/9/12/380 > > > > Rob, Jacek, could you please agree where I can put the binding? > > I'm not sure if this is a good approach. I've noticed also that > backlight bindings have been moved to leds, whereas they don't look > similarly. > > We have common.txt LED bindings, that all LED class drivers' bindings > have to follow. Neither backlight bindings nor these ones do that, > which introduces some mess. > > Eventually adding a sub-directory, e.g. remote_control could make it > somehow logically justified, but still - shouldn't bindings be > placed in the documentation directory related to the subsystem of the > driver they are predestined to? In principle I agree with you, also because I understood that the led kind of bindings are for those LEDs which main function is to emit light. There is no need for a remote control directory, because there is one already under bindings/media, where all the remote controllers are placed. Now this is a matter of interpretation, is this an IR LED used by the driver as remote controller or is this a remote controller with just an IR LED? In any case, I will wait for you and Rob to agree where is best to place the binding, then I will send a new version. Thanks, Andi