Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759545AbcKDFBk (ORCPT ); Fri, 4 Nov 2016 01:01:40 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34316 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758625AbcKDFBi (ORCPT ); Fri, 4 Nov 2016 01:01:38 -0400 MIME-Version: 1.0 In-Reply-To: <20161102082206.GE21488@amd> References: <1475092512-30555-1-git-send-email-matt@ranostay.consulting> <1475092512-30555-3-git-send-email-matt@ranostay.consulting> <20161024201443.GB5989@amd> <20161031213846.GA21014@amd> <20161102082206.GE21488@amd> From: Matt Ranostay Date: Thu, 3 Nov 2016 22:00:56 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query To: Pavel Machek Cc: Matt Ranostay , pali.rohar@gmail.com, Sebastian Reichel , kernel list , linux-arm-kernel , Linux OMAP List , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, Patrik Bachan , serge@hallyn.com, =?UTF-8?B?TWlja3Vsw6HFoSBRd2VydHo=?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 51 On Wed, Nov 2, 2016 at 1:22 AM, Pavel Machek wrote: > Hi! > >> >> >> Better then previous one. >> >> >> >> >> >> But my version of bq27xxx_battery.c already contains this: >> >> > >> >> > This is for allowing udev rule to set the properties as well. >> >> > otherwise a kinda crude RUN = " echo value > >> >> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required. >> >> >> >> Any thoughts on this? >> > >> > I'd say echo value > >> > /sys/module/bq27xxx_battery/parameters/poll_interval .. is quite >> > adequate solution...? >> > >> > Alternatively, convince us that something else is useful for everyone, >> > and we can do the right thing (poll more often when battery is nearly >> > empty), automatically... >> >> Ok should have had the patchset set it per device, and not use the >> global poll_interval. Of need to add some logic to see if uses the >> global poll_interval or it's own setting. >> >> There are times where you could have multiple batteries connected to >> multiple fuel gauges, and want to up the polling interval on certain >> ones that are discharging at different rates. >> >> But of course I'll let you guys let me know if this seems useful at all. > > I agree per-device polling would be cleaner. > Ok I'll work something up for RFC. > But unless you have hardware with more than one bq27xxx, I'd avoid the > work... > > Now... its also possible that poll_interval should change itself > (within kernel) to do the right thing. > True but that is state machine territory, but I'll worry about that later... > Best regards, > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html