Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760629AbcKDIMn (ORCPT ); Fri, 4 Nov 2016 04:12:43 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:40934 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbcKDIMj (ORCPT ); Fri, 4 Nov 2016 04:12:39 -0400 MIME-Version: 1.0 In-Reply-To: <20161103084543.m4zvwhscpaa3y5ay@lukather> References: <20161103075556.29018-1-wens@csie.org> <20161103075556.29018-14-wens@csie.org> <20161103084543.m4zvwhscpaa3y5ay@lukather> From: Chen-Yu Tsai Date: Fri, 4 Nov 2016 16:12:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/14] ARM: dts: sun6i: hummingbird: Enable internal audio codec To: Maxime Ripard Cc: Chen-Yu Tsai , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Mark Rutland , Linux-ALSA , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 56 On Thu, Nov 3, 2016 at 4:45 PM, Maxime Ripard wrote: > On Thu, Nov 03, 2016 at 03:55:55PM +0800, Chen-Yu Tsai wrote: >> The Hummingbird A31 has headset and line in audio jacks and an onboard >> mic routed to the pins for the SoC's internal codec. The line out pins >> are routed to an onboard speaker amp, whose output is available on a >> pin header. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> index 9a74637f677f..48c041b75aab 100644 >> --- a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> +++ b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts >> @@ -69,6 +69,19 @@ >> }; >> }; >> >> +&codec { >> + allwinner,audio-routing = >> + "Headphone", "HP", >> + "Speaker", "LINEOUT", >> + "LINEIN", "Line In", >> + "MIC1", "Mic", >> + "MIC2", "Headset Mic", >> + "Mic", "MBIAS", >> + "Headset Mic", "HBIAS"; >> + allwinner,pa-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */ >> + status = "okay"; >> +}; >> + >> &cpu0 { >> cpu-supply = <®_dcdc3>; >> }; >> @@ -152,6 +165,13 @@ >> }; >> >> &pio { >> + codec_pa_pin: codec_pa_pin@0 { >> + allwinner,pins = "PH22"; >> + allwinner,function = "gpio_out"; >> + allwinner,drive = ; >> + allwinner,pull = ; >> + }; >> + > > This pin group isn't used anywhere. Because of the strict thing in > pinctrl, I'd say it's better to not set it, but then, the pin group is > useless. I'll drop the pinmux setting then. ChenYu