Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760939AbcKDJa0 (ORCPT ); Fri, 4 Nov 2016 05:30:26 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:36557 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756368AbcKDJaY (ORCPT ); Fri, 4 Nov 2016 05:30:24 -0400 Date: Fri, 4 Nov 2016 10:30:21 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: add port link setter Message-ID: <20161104093021.GD13959@lunn.ch> References: <20161104022336.14273-1-vivien.didelot@savoirfairelinux.com> <20161104022336.14273-8-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161104022336.14273-8-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 462 Lines: 15 On Fri, Nov 04, 2016 at 03:23:32AM +0100, Vivien Didelot wrote: > Most of the chips will have a port register control bits to force the > port's link up, down, or let normal link detection occurs. > > Implement such operation to use it later when setting duplex, etc. > > Signed-off-by: Vivien Didelot Hi Vivien Thanks for the change. Interesting choice of values. Reviewed-by: Andrew Lunn Andrew