Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761211AbcKDKSF (ORCPT ); Fri, 4 Nov 2016 06:18:05 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:50735 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbcKDKSD (ORCPT ); Fri, 4 Nov 2016 06:18:03 -0400 Subject: Re: [PATCH 1/2] ARM: dts: stm32f429: add LSI and LSE clocks To: Alexandre Torgue , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin References: <1478249577-25999-1-git-send-email-gabriel.fernandez@st.com> <1478249577-25999-2-git-send-email-gabriel.fernandez@st.com> <3974b516-d698-ab7f-efba-d768eccbd56f@st.com> CC: , , , From: Gabriel Fernandez Message-ID: <57d580c4-5a3c-4ba3-54f1-a26297796394@st.com> Date: Fri, 4 Nov 2016 11:16:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3974b516-d698-ab7f-efba-d768eccbd56f@st.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.80] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-04_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2086 Lines: 79 Hi Alexandre, On 11/04/2016 11:15 AM, Alexandre Torgue wrote: > Gabriel, > > On 11/04/2016 09:52 AM, gabriel.fernandez@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds lsi / lse oscillators. These clocks can be use by >> RTC clocks. >> The clock drivers needs to disable the power domain write protection >> using >> syscon / regmap to enable these clocks. >> > > Is it the same than you sent in last series ? If yes I will take it > directly as review has already been done. > Yes BR Gabriel. > regards > Alex > >> Signed-off-by: Gabriel Fernandez >> --- >> arch/arm/boot/dts/stm32f429.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm/boot/dts/stm32f429.dtsi >> b/arch/arm/boot/dts/stm32f429.dtsi >> index 336ee4f..2700449 100644 >> --- a/arch/arm/boot/dts/stm32f429.dtsi >> +++ b/arch/arm/boot/dts/stm32f429.dtsi >> @@ -56,6 +56,18 @@ >> compatible = "fixed-clock"; >> clock-frequency = <0>; >> }; >> + >> + clk-lse { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <32768>; >> + }; >> + >> + clk-lsi { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <32000>; >> + }; >> }; >> >> soc { >> @@ -185,6 +197,11 @@ >> interrupts = <1>, <2>, <3>, <6>, <7>, <8>, <9>, <10>, >> <23>, <40>, <41>, <42>, <62>, <76>; >> }; >> >> + pwrcfg: power-config@40007000 { >> + compatible = "syscon"; >> + reg = <0x40007000 0x400>; >> + }; >> + >> pin-controller { >> #address-cells = <1>; >> #size-cells = <1>; >> @@ -340,6 +357,7 @@ >> compatible = "st,stm32f42xx-rcc", "st,stm32-rcc"; >> reg = <0x40023800 0x400>; >> clocks = <&clk_hse>; >> + st,syscfg = <&pwrcfg>; >> }; >> >> dma1: dma-controller@40026000 { >>