Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761810AbcKDLR1 convert rfc822-to-8bit (ORCPT ); Fri, 4 Nov 2016 07:17:27 -0400 Received: from gloria.sntech.de ([95.129.55.99]:52154 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755482AbcKDLR0 (ORCPT ); Fri, 4 Nov 2016 07:17:26 -0400 From: Heiko Stuebner To: Andy Yan Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6] ARM: dts: rockchip: add rockchip RK1108 Evaluation board Date: Fri, 04 Nov 2016 12:17:11 +0100 Message-ID: <2909103.zaARAZdmtv@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.26.0; x86_64; ; ) In-Reply-To: References: <1478175975-11779-1-git-send-email-andy.yan@rock-chips.com> <3057904.hZPZRUIUZe@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 22 Am Freitag, 4. November 2016, 18:54:35 CET schrieb Andy Yan: > Hi Heiko: > > On 2016年11月04日 18:03, Heiko Stuebner wrote: > > Am Donnerstag, 3. November 2016, 20:43:59 CET schrieb Andy Yan: > >> RK1108EVB is designed by Rockchip for CVR field. > >> This patch add basic support for it, which can boot with > >> initramfs into shell. > >> > >> Signed-off-by: Andy Yan > > > > looks good, the only thing I can also change myself is moving the board in > > the rockchip.txt to the block of Rockchip boards (i.e. sorting by > > manufacturer and board name). > > > > > > Heiko > > You mean it's better to put it between "Rockchip RK3368 evb" and > "Rockchip PX5 Evaluation board"? if so, I will change it in next version. yep, that is the location I also would've moved it to :-) .