Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933927AbcKDLVy (ORCPT ); Fri, 4 Nov 2016 07:21:54 -0400 Received: from mail.skyhub.de ([78.46.96.112]:49577 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755295AbcKDLVx (ORCPT ); Fri, 4 Nov 2016 07:21:53 -0400 Date: Fri, 4 Nov 2016 12:21:50 +0100 From: Borislav Petkov To: Aaron Miller , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] EDAC: expose per-dimm error counts in sysfs Message-ID: <20161104112150.5lfb5bb7gklb2jfg@pd.tnic> References: <20161025232551.3270769-1-aaronmiller@fb.com> <20161103220153.3997328-1-aaronmiller@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161103220153.3997328-1-aaronmiller@fb.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 30 On Thu, Nov 03, 2016 at 03:01:53PM -0700, Aaron Miller wrote: > The old 'csrowX' sysfs directories had per-csrow error counters, but the > new 'dimmX' directories do not currently expose error counts. > > EDAC already keeps these counts, add them to sysfs so per-dimm counts > are still available when CONFIG_EDAC_LEGACY_SYSFS=n > > Signed-off-by: Aaron Miller > --- > > Notes: > v2: Add commit messsage and documentation > v3: Add ReST documentation on top of Mauro's patchset > > Documentation/ABI/testing/sysfs-devices-edac | 17 +++++++++++++ > Documentation/admin-guide/ras.rst | 20 +++++++++++++++ > drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++ > 3 files changed, 75 insertions(+) LGTM. Acked-by: Borislav Petkov Mauro, I'm assuming you're picking up this. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.