Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934427AbcKDM27 (ORCPT ); Fri, 4 Nov 2016 08:28:59 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:33652 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934183AbcKDM24 (ORCPT ); Fri, 4 Nov 2016 08:28:56 -0400 MIME-Version: 1.0 In-Reply-To: <1478015868-10309-2-git-send-email-andrew.smirnov@gmail.com> References: <1478015868-10309-1-git-send-email-andrew.smirnov@gmail.com> <1478015868-10309-2-git-send-email-andrew.smirnov@gmail.com> From: Linus Walleij Date: Fri, 4 Nov 2016 13:28:55 +0100 Message-ID: Subject: Re: [PATCH 01/14] pinctrl-sx150x: Rely on of_modalias_node for OF matching To: Andrey Smirnov Cc: "linux-gpio@vger.kernel.org" , Neil Armstrong , "linux-kernel@vger.kernel.org" , Chris Healy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 32 On Tue, Nov 1, 2016 at 4:57 PM, Andrey Smirnov wrote: > None of the OF match table entries contain any compatiblity strings that > could not be matched against using i2c_device_id table above and > of_modalias_node. Besides that entries in OF match table do not cary > proper device variant information which is need by the drive. Those two > facts combined, IMHO, make a compelling case for removal of that code > altogether. > > Signed-off-by: Andrey Smirnov (...) > -static const struct of_device_id sx150x_of_match[] = { > - { .compatible = "semtech,sx1508q" }, > - { .compatible = "semtech,sx1509q" }, > - { .compatible = "semtech,sx1506q" }, > - { .compatible = "semtech,sx1502q" }, > - {}, > -}; I'm a bit hesitant about this since we should ideally first match on the compatible string for any device. We have tried to alleviate the situation in I2C devices but it has been a bit so-so. It would be best if we make a separate patch after this tjat adds it back, set the variant data also in the .data of the match and use of_device_get_match_data(). It's no strong preference: I will still apply this patch set because it is overall very very good. Yours, Linus Walleij