Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934842AbcKDNs1 (ORCPT ); Fri, 4 Nov 2016 09:48:27 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33153 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934360AbcKDNsZ (ORCPT ); Fri, 4 Nov 2016 09:48:25 -0400 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: References: <1477380887-21333-1-git-send-email-mszeredi@redhat.com> <1477380887-21333-4-git-send-email-mszeredi@redhat.com> <20161028161534.GM19539@ZenIV.linux.org.uk> From: Miklos Szeredi Date: Fri, 4 Nov 2016 14:48:22 +0100 Message-ID: Subject: Re: [PATCH 3/3] ovl: redirect on rename-dir To: Amir Goldstein Cc: Al Viro , Miklos Szeredi , "linux-unionfs@vger.kernel.org" , Guillem Jover , Raphael Hertzog , linux-fsdevel , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 26 On Fri, Nov 4, 2016 at 10:29 AM, Amir Goldstein wrote: > You did not address my comment about the 'stack' allocation overflow > in ovl_lookup > I believe the (possible) overflow is demonstrated by the following debug patch: Oops, missed that. Good spotting! And there's more shit that unionfs-testsuite didn't discover (not even involving multiple layers): rm -rf /lower /upper /work mkdir -p /lower/a/b/c /upper /work mount -t overlay overlay -oupperdir=/upper,lowerdir=/lower,workdir=/work /mnt mv /mnt/a /mnt/z mv /mnt/z/b /mnt/q ls /mnt/q umount /mnt mount -t overlay overlay -oupperdir=/upper,lowerdir=/lower,workdir=/work /mnt ls /mnt/q umount /mnt Next update coming up... Thanks, Miklos