Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934833AbcKDOG3 (ORCPT ); Fri, 4 Nov 2016 10:06:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbcKDOG2 (ORCPT ); Fri, 4 Nov 2016 10:06:28 -0400 From: Jes Sorensen To: Joe Perches Cc: John Heenan , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower References: <20161030102112.GA5789@cube> <1478162497.1924.16.camel@perches.com> Date: Fri, 04 Nov 2016 09:56:00 -0400 In-Reply-To: <1478162497.1924.16.camel@perches.com> (Joe Perches's message of "Thu, 03 Nov 2016 01:41:37 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 04 Nov 2016 14:06:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 17 Joe Perches writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?printk: re-organize log_output() to be more legible") > which does both of those: c99 // comments and > 80 columns. > > Absolutes are for zealots. What Linus does in his code, is totally up to him. What I pull into the driver that *I* maintain, is up to me. It is perfectly normal to expect submitters to respect the coding style of the piece of code they are trying to edit. Jes