Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935230AbcKDOxL (ORCPT <rfc822;w@1wt.eu>);
        Fri, 4 Nov 2016 10:53:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56012 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934112AbcKDOxJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Nov 2016 10:53:09 -0400
Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS
 features to kvm guest
To: Borislav Petkov <bp@alien8.de>, He Chen <he.chen@linux.intel.com>
References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com>
 <20161104105235.qbqvmsv4ikajvjtu@pd.tnic>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Luwei Kang <luwei.kang@intel.com>,
        Piotr Luc <Piotr.Luc@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
Date: Fri, 4 Nov 2016 15:53:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161104105235.qbqvmsv4ikajvjtu@pd.tnic>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 04 Nov 2016 14:53:08 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1667
Lines: 67



On 04/11/2016 11:52, Borislav Petkov wrote:
> Please CC me on your future submissions, thanks.
> 
> On Fri, Nov 04, 2016 at 03:07:19PM +0800, He Chen wrote:
>> The spec can be found in Intel Software Developer Manual or in
>> Instruction Set Extensions Programming Reference.
> 
> This commit message is completely useless. Write commit messages in
> the way as if you're explaining to another person *why* this change is
> needed and that other person doesn't have an idea what you're doing.
> 
>> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
>> Signed-off-by: He Chen <he.chen@linux.intel.com>
> 
> This SOB chain means what exactly?
> 
>> ---
>> Changes in v3:
>> * add a helper in scattered.c to get scattered leaf.
> 
> The modification to scattered et al without the kvm use should be a
> separate patch.

With no usage?  Sounds like a good use of Acked-by. :)

>> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
>> +			     enum cpuid_regs_idx reg)
> 
> Align arguments on the opening brace.

They are aligned.

Paolo

>> +{
>> +	u32 cpuid_val = 0;
>> +	const struct cpuid_bit *cb;
> 
> 
> Please sort function local variables declaration in a reverse christmas
> tree order:
> 
> 	<type> longest_variable_name;
> 	<type> shorter_var_name;
> 	<type> even_shorter;
> 	<type> i;
> 
>> +
>> +	for (cb = cpuid_bits; cb->feature; cb++) {
>> +
>> +		if (level > cb->level)
>> +			continue;
>> +
>> +		if (level < cb->level)
>> +			break;
>> +
>> +		if (reg == cb->reg && sub_leaf == cb->sub_leaf) {
>> +			if (cpu_has(&boot_cpu_data, cb->feature))
>> +				cpuid_val |= BIT(cb->bit);
>> +		}
>> +	}
>> +
>> +	return cpuid_val;
>> +}
>