Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935365AbcKDPGm (ORCPT ); Fri, 4 Nov 2016 11:06:42 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51710 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932271AbcKDPGk (ORCPT ); Fri, 4 Nov 2016 11:06:40 -0400 Date: Fri, 4 Nov 2016 16:06:37 +0100 From: Borislav Petkov To: Paolo Bonzini Cc: He Chen , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Luwei Kang , Piotr Luc Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest Message-ID: <20161104150637.ejyxq5rfwcwggo3q@pd.tnic> References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com> <20161104105235.qbqvmsv4ikajvjtu@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 23 On Fri, Nov 04, 2016 at 03:53:02PM +0100, Paolo Bonzini wrote: > > The modification to scattered et al without the kvm use should be a > > separate patch. > > With no usage? Sounds like a good use of Acked-by. :) I don't understand what do you mean here? > >> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf, > >> + enum cpuid_regs_idx reg) > > > > Align arguments on the opening brace. > > They are aligned. Right you are. I need to look into why those spaces get eaten in vim. Looks like something is replacing 4 spaces with a single one... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.