Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935712AbcKDPSY convert rfc822-to-8bit (ORCPT ); Fri, 4 Nov 2016 11:18:24 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:43642 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935627AbcKDPSW (ORCPT ); Fri, 4 Nov 2016 11:18:22 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: "David S. Miller" , netdev , LKML , Mason , Andrew Lunn Subject: Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level References: <581CA300.1060609@laposte.net> Date: Fri, 04 Nov 2016 15:18:17 +0000 In-Reply-To: <581CA300.1060609@laposte.net> (Sebastian Frias's message of "Fri, 4 Nov 2016 16:02:24 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 37 Sebastian Frias writes: > The delay can be applied at PHY or MAC level, but since > PHY drivers will apply the delay at PHY level when using > one of the "internal delay" declinations of RGMII mode > (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again > at MAC level causes issues. The Broadcom GENET driver does the same thing. > Signed-off-by: Sebastian Frias > --- > drivers/net/ethernet/aurora/nb8800.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c > index b59aa35..d2855c9 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev) > break; > > case PHY_INTERFACE_MODE_RGMII_TXID: > - pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY; > + pad_mode = PAD_MODE_RGMII; > break; > > default: > -- > 1.7.11.2 If this change is correct (and I'm not convinced it is), that case should be merged with the one above it and PHY_INTERFACE_MODE_RGMII_RXID added as well. -- M?ns Rullg?rd