Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935948AbcKDPqC (ORCPT ); Fri, 4 Nov 2016 11:46:02 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33476 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934249AbcKDPqB (ORCPT ); Fri, 4 Nov 2016 11:46:01 -0400 Date: Sat, 5 Nov 2016 00:44:51 +0900 From: Sergey Senozhatsky To: Paul Burton Cc: Sergey Senozhatsky , Larry Finger , Michael Ellerman , Andreas Schwab , Andrew Morton , Borislav Petkov , Petr Mladek , Tejun Heo , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3] console: use first console if stdout-path device doesn't appear Message-ID: <20161104153852.GA422@swordfish> References: <2c67e39b-fc33-918a-774e-d9238e837c03@lwfinger.net> <20161103125758.3415-1-paul.burton@imgtec.com> <20161103174040.GB423@swordfish> <2317993.vxfTP7Yo3N@np-p-burton> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2317993.vxfTP7Yo3N@np-p-burton> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 26 Hi Paul, On (11/03/16 21:17), Paul Burton wrote: > > [..] > > > + * The device tree stdout-path chosen node property was > > > + * specified so we don't want to enable the first > > > + * registered console just now in order to give the > > > + * device indicated by stdout-path a chance to be > > > + * registered first. Do however keep track of the > > > + * first console we see so that we can fall back to > > > + * using it if we don't see the desired device, either > > > + * because stdout-path isn't valid, or because we have > > > + * no driver for the device or our driver doesn't call > > > + * of_console_check(). See printk_late_init() for this > > > + * fallback. > > > > if the path is not valid then correct the path. no? > > ...but what if the path is valid and we simply don't have a driver for the > device it references? As I said in that comment we may not have a driver at > all. well, I suppose, in this case normally one would go and enable the missing .config option. no? -ss