Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS
 features to kvm guest
To: Borislav Petkov <bp@alien8.de>
References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com>
 <20161104105235.qbqvmsv4ikajvjtu@pd.tnic>
 <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
 <20161104150637.ejyxq5rfwcwggo3q@pd.tnic>
 <39d57b21-671d-8c25-8d25-ba2cfd0dc4f9@redhat.com>
 <20161104155752.e6gf7hev3tklbw6m@pd.tnic>
Cc: He Chen <he.chen@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Luwei Kang <luwei.kang@intel.com>,
        Piotr Luc <Piotr.Luc@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <19ce3689-8a73-9692-e48b-95a2cbdc8dc9@redhat.com>
Date: Fri, 4 Nov 2016 16:58:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161104155752.e6gf7hev3tklbw6m@pd.tnic>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 644
Lines: 21


On 04/11/2016 16:57, Borislav Petkov wrote:
> On Fri, Nov 04, 2016 at 04:13:24PM +0100, Paolo Bonzini wrote:
>> I mean that the changes to scattered.c are small, so it makes no sense
>> to split them. With an Acked-by I could simply take the patch into my
>> tree.
> 
> On no, it is not about the size or which tree it goes thru - rather that
> having stuff separated conceptually makes the patches much more clear.
> 
> The patch order would be
> 
> * modify scattered.c to return leaf
> * add user of new function
> 
> which also makes review almost trivial.

That's fine by me of course.  I would probably take both patches anyway.

Paolo