Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936446AbcKDQXY (ORCPT ); Fri, 4 Nov 2016 12:23:24 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36424 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934730AbcKDQXW (ORCPT ); Fri, 4 Nov 2016 12:23:22 -0400 Subject: Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations To: Sebastian Frias , =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , "David S. Miller" , netdev References: <581CA3D0.6080808@laposte.net> Cc: LKML , Mason , Andrew Lunn From: Florian Fainelli Message-ID: <8c491fff-4849-fa9b-0a0a-5a7a6870120d@gmail.com> Date: Fri, 4 Nov 2016 09:23:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <581CA3D0.6080808@laposte.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1779 Lines: 52 On 11/04/2016 08:05 AM, Sebastian Frias wrote: > Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") > and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal > delay for tx and rx only") added several RGMII declinations: > PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and > PHY_INTERFACE_MODE_RGMII_TXID to deal with internal delays. > > Those are all RGMII modes (1Gbit) and must be considered that way when > setting the MAC Mode or the Pads Mode for the HW to work properly. > > Signed-off-by: Sebastian Frias > --- > drivers/net/ethernet/aurora/nb8800.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c > index d2855c9..6230ace 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -609,7 +609,10 @@ static void nb8800_mac_config(struct net_device *dev) > mac_mode |= HALF_DUPLEX; > > if (gigabit) { > - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII) > + if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII || > + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_ID || > + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_RXID || > + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_TXID) phy_interface_is_rgmii(phydev)? > mac_mode |= RGMII_MODE; > > mac_mode |= GMAC_MODE; > @@ -1278,9 +1281,8 @@ static int nb8800_tangox_init(struct net_device *dev) > break; > > case PHY_INTERFACE_MODE_RGMII: > - pad_mode = PAD_MODE_RGMII; > - break; > - > + case PHY_INTERFACE_MODE_RGMII_ID: > + case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > pad_mode = PAD_MODE_RGMII; > break; > -- Florian