Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936243AbcKDQ3j (ORCPT ); Fri, 4 Nov 2016 12:29:39 -0400 Received: from smtpoutz25.laposte.net ([194.117.213.100]:54721 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756830AbcKDQ3i (ORCPT ); Fri, 4 Nov 2016 12:29:38 -0400 Subject: Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations To: Florian Fainelli , =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , "David S. Miller" , netdev References: <581CA3D0.6080808@laposte.net> <8c491fff-4849-fa9b-0a0a-5a7a6870120d@gmail.com> Cc: LKML , Mason , Andrew Lunn From: Sebastian Frias Message-ID: <581CB76E.8060300@laposte.net> Date: Fri, 4 Nov 2016 17:29:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <8c491fff-4849-fa9b-0a0a-5a7a6870120d@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-VR-SrcIP: 92.154.11.170 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelvddrkeelgdekjecutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjegrtddtfeehnecuhfhrohhmpefu X-VR-Cause-4: vggsrghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgvrdhnvghtqeenucfkphepledv X-VR-Cause-5: rdduheegrdduuddrudejtdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopegludej X-VR-Cause-6: vddrvdejrddtrddvudegngdpihhnvghtpeelvddrudehgedruddurddujedtpdhmrghilhhfrhhomhep X-VR-Cause-7: shhfkeegsehlrghpohhsthgvrdhnvghtpdhrtghpthhtohepfhdrfhgrihhnvghllhhisehgmhgrihhl X-VR-Cause-8: rdgtohhm X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1899 Lines: 54 On 11/04/2016 05:23 PM, Florian Fainelli wrote: > > > On 11/04/2016 08:05 AM, Sebastian Frias wrote: >> Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") >> and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal >> delay for tx and rx only") added several RGMII declinations: >> PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and >> PHY_INTERFACE_MODE_RGMII_TXID to deal with internal delays. >> >> Those are all RGMII modes (1Gbit) and must be considered that way when >> setting the MAC Mode or the Pads Mode for the HW to work properly. >> >> Signed-off-by: Sebastian Frias >> --- >> drivers/net/ethernet/aurora/nb8800.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c >> index d2855c9..6230ace 100644 >> --- a/drivers/net/ethernet/aurora/nb8800.c >> +++ b/drivers/net/ethernet/aurora/nb8800.c >> @@ -609,7 +609,10 @@ static void nb8800_mac_config(struct net_device *dev) >> mac_mode |= HALF_DUPLEX; >> >> if (gigabit) { >> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII) >> + if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII || >> + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_ID || >> + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_RXID || >> + priv->phy_mode == PHY_INTERFACE_MODE_RGMII_TXID) > > phy_interface_is_rgmii(phydev)? Thanks! I'll post an update. > >> mac_mode |= RGMII_MODE; >> >> mac_mode |= GMAC_MODE; >> @@ -1278,9 +1281,8 @@ static int nb8800_tangox_init(struct net_device *dev) >> break; >> >> case PHY_INTERFACE_MODE_RGMII: >> - pad_mode = PAD_MODE_RGMII; >> - break; >> - >> + case PHY_INTERFACE_MODE_RGMII_ID: >> + case PHY_INTERFACE_MODE_RGMII_RXID: >> case PHY_INTERFACE_MODE_RGMII_TXID: >> pad_mode = PAD_MODE_RGMII; >> break; >> >