Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964920AbcKDQzJ convert rfc822-to-8bit (ORCPT ); Fri, 4 Nov 2016 12:55:09 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:18001 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932283AbcKDQzI (ORCPT ); Fri, 4 Nov 2016 12:55:08 -0400 From: Matthew Fortune To: Maciej Rozycki , Guenter Roeck CC: Ralf Baechle , "linux-mips@linux-mips.org" , "linux-kernel@vger.kernel.org" , James Hogan Subject: RE: [PATCH] MIPS: VDSO: Always select -msoft-float Thread-Topic: [PATCH] MIPS: VDSO: Always select -msoft-float Thread-Index: AQHSNpqpZSKpsmkzvECGzdemX2t3KKDIyilQgAAoI4CAAAwsgIAACz2A Date: Fri, 4 Nov 2016 16:55:05 +0000 Message-ID: <6D39441BF12EF246A7ABCE6654B0235380AB822B@HHMAIL01.hh.imgtec.org> References: <1477843551-21813-1-git-send-email-linux@roeck-us.net> <20161101233038.GA25472@roeck-us.net> <6D39441BF12EF246A7ABCE6654B0235380AB79B7@HHMAIL01.hh.imgtec.org> <20161104152603.GB12009@roeck-us.net> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.152.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 20 Maciej Rozycki writes: > On Fri, 4 Nov 2016, Guenter Roeck wrote: > > > > As above, unless absolutely critical to have floating point code > > > then the vDSO should just avoid all FP related issues and build > soft-float. ... > > Anyway, isn't the kernel supposed to not use floating point operations > > in the first place ? Is this different for vDSO ? > > This code is executed in the user mode so while floating-point code may > not be needed there, not at least right now, there's actually nothing > which should stop us from from adding some should such a need arise. Indeed. For now though the switch to -msoft-float is the simplest solution isn't it? Matthew