Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936251AbcKDSq4 (ORCPT ); Fri, 4 Nov 2016 14:46:56 -0400 Received: from foss.arm.com ([217.140.101.70]:38460 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934729AbcKDSq4 (ORCPT ); Fri, 4 Nov 2016 14:46:56 -0400 Date: Fri, 4 Nov 2016 12:46:52 -0600 From: Catalin Marinas To: Pratyush Anand Cc: steve.capper@linaro.org, srikar@linux.vnet.ibm.com, vijaya.kumar@caviumnetworks.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, oleg@redhat.com, wcohen@redhat.com, linux-arm-kernel@lists.infradead.org, dave.long@redhat.com Subject: Re: [PATCH V3 0/6] ARM64: Uprobe support added Message-ID: <20161104184652.rxllldll4qfe7qdn@localhost> References: <20161104174951.vj4il3xkdy7a2ln7@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161104174951.vj4il3xkdy7a2ln7@localhost> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1605 Lines: 28 On Fri, Nov 04, 2016 at 11:49:51AM -0600, Catalin Marinas wrote: > On Wed, Nov 02, 2016 at 02:40:40PM +0530, Pratyush Anand wrote: > > Pratyush Anand (6): > > arm64: kprobe: protect/rename few definitions to be reused by uprobe > > arm64: kgdb_step_brk_fn: ignore other's exception > > arm64: Handle TRAP_TRACE for user mode as well > > arm64: Handle TRAP_BRKPT for user mode as well > > arm64: introduce mm context flag to keep 32 bit task information > > arm64: Add uprobe support > > I queued the patches for 4.10. I will push them into -next sometime next > week once I do some testing (I'm currently at the LPC). I spoke too soon. With these patches on top of 4.9-rc3, defconfig together with FTRACE and UPROBE_EVENT enabled I get: In file included from /work/Linux/linux-2.6-aarch64/arch/arm64/kernel/probes/decode-insn.c:20:0: /work/Linux/linux-2.6-aarch64/arch/arm64/include/asm/kprobes.h:52:5: error: conflicting types for 'kprobe_fault_handler' int kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr); ^~~~~~~~~~~~~~~~~~~~ In file included from /work/Linux/linux-2.6-aarch64/arch/arm64/kernel/probes/decode-insn.c:17:0: /work/Linux/linux-2.6-aarch64/include/linux/kprobes.h:398:90: note: previous definition of 'kprobe_fault_handler' was here static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr) ^ /work/Linux/linux-2.6-aarch64/scripts/Makefile.build:290: recipe for target 'arch/arm64/kernel/probes/decode-insn.o' failed -- Catalin