Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756906AbcKDUdG (ORCPT ); Fri, 4 Nov 2016 16:33:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57660 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755515AbcKDUdD (ORCPT ); Fri, 4 Nov 2016 16:33:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 96C85611D2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 4 Nov 2016 13:33:02 -0700 From: Stephen Boyd To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Michael Turquette , Thomas Petazzoni , linux-clk@vger.kernel.org Subject: Re: [PATCH 04/10] clk: mvebu: make ap806-system-controller explicitly non-modular Message-ID: <20161104203302.GH16026@codeaurora.org> References: <20160704211220.5685-1-paul.gortmaker@windriver.com> <20160704211220.5685-5-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160704211220.5685-5-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 36 On 07/04, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/clk/mvebu/Kconfig:config ARMADA_AP806_SYSCON > drivers/clk/mvebu/Kconfig: bool > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Thomas Petazzoni > Cc: linux-clk@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project