Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbcKEKdh (ORCPT ); Sat, 5 Nov 2016 06:33:37 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34659 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbcKEKde (ORCPT ); Sat, 5 Nov 2016 06:33:34 -0400 Subject: Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support To: Jon Mason References: <1478236262-3351-1-git-send-email-jon.mason@broadcom.com> <1478236262-3351-8-git-send-email-jon.mason@broadcom.com> <69ecd9b9-d495-9dfa-ad26-4fa622d951a0@cogentembedded.com> <20161104163024.GA6128@broadcom.com> Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Sat, 5 Nov 2016 13:33:31 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161104163024.GA6128@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 37 On 11/4/2016 7:30 PM, Jon Mason wrote: >>> Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device >>> tree >>> >>> Signed-off-by: Jon Mason >>> --- >>> arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +++++ >>> arch/arm64/boot/dts/broadcom/ns2.dtsi | 12 ++++++++++++ >>> 2 files changed, 17 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts >>> index b09f3bc..c4d5442 100644 >>> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts >>> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts >>> @@ -56,6 +56,10 @@ >>> }; >>> }; >>> >>> +&enet { >>> + status = "ok"; >> >> The spec dictates it should be "okay" (although "ok" is also recognized). > > The rest of the file uses "ok". So, the addition above is consistent > with the other entries. > > Perhaps a patch outside this series to convert the entire file from > "ok" to "okay" would be acceptable to you. OK, it would... > > Thanks, > Jon MBR, Sergei