Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755744AbcKENoo (ORCPT <rfc822;w@1wt.eu>);
        Sat, 5 Nov 2016 09:44:44 -0400
Received: from mail-by2nam01on0048.outbound.protection.outlook.com ([104.47.34.48]:19376
        "EHLO NAM01-BY2-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1755684AbcKENol (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 5 Nov 2016 09:44:41 -0400
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Christian.Koenig@amd.com; 
Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name()
To: Eric Engestrom <eric@engestrom.ch>, <linux-kernel@vger.kernel.org>
References: <20161105012344.GA28349@engestrom.ch>
 <20161105013325.3889-1-eric@engestrom.ch>
CC: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        "Alex Deucher" <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Xinliang Liu <z.liuxinliang@hisilicon.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "VMware Graphics" <linux-graphics-maintainer@vmware.com>,
        Sinclair Yeh <syeh@vmware.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        Tom St Denis <tom.stdenis@amd.com>,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel.daenzer@amd.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Emily Deng <Emily.Deng@amd.com>, Chunming Zhou <David1.Zhou@amd.com>,
        "Flora Cui" <Flora.Cui@amd.com>,
        Vitaly Prosyak <vitaly.prosyak@amd.com>,
        Ken Wang <Qingqing.Wang@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        Alexandre Demers <alexandre.f.demers@gmail.com>,
        Junwei Zhang <Jerry.Zhang@amd.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        "Chris Wilson" <chris@chris-wilson.co.uk>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        <dri-devel@lists.freedesktop.org>, <intel-gfx@lists.freedesktop.org>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <cc7acbea-a721-22b4-67d3-22198decced6@amd.com>
Date: Sat, 5 Nov 2016 13:11:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161105013325.3889-1-eric@engestrom.ch>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [2a02:908:1251:7981:851d:2f6a:f102:8e4]
X-ClientProxiedBy: AMSPR04CA0038.eurprd04.prod.outlook.com (10.242.87.156) To
 DM5PR12MB1308.namprd12.prod.outlook.com (10.168.238.7)
X-MS-Office365-Filtering-Correlation-Id: 39e5cfeb-a8b9-4aed-1efd-08d40574ed05
X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1308;2:P0iqQDXVcb2itNtQhLgb8PxuqHKurkwEXn+P1OhdxtmSrWcUVd8ryO5W0KUqKPTgknWhCmd6DIyKO7loG0bgXCOfjE68K0dvYOC+M6HMrroje+sL9Lg5m6ZCw9cMTz21W/IjXiJPYAwepiOzVmDvlHrVOPD6xwOvwy71hSHLJWrIC9uDxWWta3C8GnoEixLex3jKlsoOtSDruwYjg4qOaA==;3:8W25h/V/zOrT/dN/dJfRpfK4pb03b6TVBIbgmGYo8nGpJ0twW7nINzz1WdQadJLaL+8cOaD1sa6SPQR/YrASRktvaLqBXgl8w0lvuy6fuLFEpU2X7lbZv6J35J+hrp2zMOTe4mJfLr7maZRlYlRabw==;25:YsZ9vwzQM14R+nYaZb0tzKvfTpkydhnBxL/YoJQqVkX2gcK++o3MpOFk95euMn73ts9SzLN2VjeePnUCAt6L17yF0B6dVi+ZJlLiWJrfGUGVXNs7/b0Y0Kb2VmjvfRH6wUA+bssuvn0uUGB4jg/+GrYkzpWjtCTIM2AHqg6NJQPqH38iNMpPxC67m2eJhoNBkQzgYv27UZO5WpRpw9ZspechjqxKtqU1iAP3YEvv6deoJ+eFgTDTnZIJFD5NIDEXixSsQ4c2oc/iCg4qL5RsnqlPsmzVeCf0bnzI20yzQZFvJBucbKD1CXsSGH0P+dYXZLZIhcMWCqeOIa77yOGnQrjSzmXoaugrB2UDx4BzGdVQ0ed7zK5IF9mrbk/Kbvb4qE+6CEMUHPJYg12PvLm44payzZq+DiJx0zdk/zDuAn4=
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1308;
X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1308;31:ucmvNccV/yg4U2yaHlrdJnSNjbhV80/aUW7njNjOZzV9FDVIK18wIIrM+JO+Wx3kKraYoHX6mRYg60amI12CEofW36LI0Q+koBubR9eV3r4yew02b5RTOA8NWhYLskFp0VDNhbOvI3a16naA4084oyrPrGku6QC4xp8pd6b7dgfPBXSLdIeG4e/5Uzq+Thd3xp8uzfSoXOoagn7XS0fCmf2S555qztg9hEzbn8Hq95ugHFPRZzyGj8EQJrdQ8ye5OhUoAaPCw8waEu/SNLJfPg==;20:SNqGkkI9Mhw7Yk3gBmSULzrULN1Z0bLW9q4zcqp4vFN2Mq2HwYYcPz21nSR6yIRB6Zatp6wYUnF4VHtyr1AMd61wzUIe+t2Hj+Mp5JQx09F1OftgShmIU1hJBDZa/snJW7GSR3KBUhzqmgA97SJJgR43t5eisqxylLo7P2dZ7HixGdgO/QC3Wy8vN0PViASghdA3L7hNskSQi8qNPB1BhW+c+IfyngYF0KLL3+2QpnGSHKlpd7h4vqM6mLEw8MN8mbCgRuRA6u6ctuitn1WNKW3oM+whxk5G6hAb5BbMvlin9ZMtpc7h0JUnhGnvluYtaHHjNLaBKxQeAM7QbNPw6QiYoEYkTh42Fn8ZHcQ22dATICrAgIV3wRs5sfDTLoFtt5eF/uSfb1bRYW4B3r1tJEFaN4Qj0XVGU37lMjiUzkkt7t8ke/eC6ECi5ksocc1rnbIzTMAyTuRj7jeOmg7G4niD0FPaOKIOZLUBei2unGjj6QcD77bweVhYgfw844xL
X-Microsoft-Antispam-PRVS: <DM5PR12MB1308272A6995154F93FA77AB83A50@DM5PR12MB1308.namprd12.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(131327999870524);
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DM5PR12MB1308;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1308;
X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1308;4:mbqopK5yVXE9iRv2as2X/v2naPq3FH8LV9F7VYyV8twcik96/Jg1IDw0XQWBLbr0IdoSeqsx/FryxOem9aUo6QXqHIWPUhtZjTqU76QfdBSp5lVEmXqP08uJFhZPpT+9h2oTUpJJ+hiaZLY0u8TQnFLeWJTVeM8Q7abZDeQutkBaRTB/2ufld8lN5knJfrNkaMGYC1+PtbskeRu06ohLZJ/mNjUYV7p/MiIReHjT4/89QdOiRAG9pFVuX1O63klXxbbGZxYyyF1J1+YXb2mt6uSMCQIUGwZyCHA3K3kUmLMjMuYl2c3ir17aGmq0BML5iNxut5xly8VPHmfBi5w1xpKKnGJeLgaLJ1DcDZ3sH8uJcNv3iN00ths1q4IH/gj59VZTo2PAPZRU3l1SNQeD4wr9JSS6tQnf8BVFnOl/a59x7Ydij4E8b9L9YoL3zTdiRXclpHHbjVvlP2sboL0taA==
X-Forefront-PRVS: 011787B9DD
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(189998001)(101416001)(6116002)(31686004)(86362001)(31696002)(1706002)(5660300001)(586003)(65826007)(54356999)(76176999)(50466002)(50986999)(42186005)(47776003)(5001770100001)(97736004)(64126003)(65806001)(65956001)(92566002)(8676002)(23676002)(77096005)(2950100002)(2906002)(81156014)(305945005)(36756003)(7736002)(81166006)(4001350100001)(7846002)(230700001)(7416002)(4326007)(6666003)(106356001)(83506001)(105586002)(68736007)(33646002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1308;H:[IPv6:2a02:908:1251:7981:851d:2f6a:f102:8e4];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMzA4OzIzOjNGVzVxRWVxdDJQT1NFVk1OTlJJMENrM0NY?=
 =?utf-8?B?YUh5L2QyenErcmZJMVVqZXdWSG1DSnp6VEJ4WmNwZHprY3hHTTc3ZXdlYzNu?=
 =?utf-8?B?aHhoT0YyaWdWZkxOZlVwY3BoNFBQamJoUDZoUlRTanBqaVI1TWZiSnZVM2JN?=
 =?utf-8?B?UUJ3ZWI4ZE5ZZ1NtZ1BhOTl3d21tWmRmbExzOC9LYmFUdWtkcWZhczdJUUhq?=
 =?utf-8?B?YkcyK1Y0M1Jhcm5ONEtXT0tjTWxFb1JjbjZhRktQNlh6UXIwWm5hUW9BSURj?=
 =?utf-8?B?NDZUaENOSzYwNUhPVUF2VUtLK0ZpZHU2WGhIZjlURkJ3ZklyNTR3UjQ1ZWVN?=
 =?utf-8?B?Q3NvOHphKy9KcGl5Nk0wQzd2U1QxV1daWUp6S0hQSHBiQlRZY3V0NDhCdGpt?=
 =?utf-8?B?OGZCSDd2cERuWExKNm16Ky9rZG5HSDVLSkxVUHA2WGl1aS9WOSt6VWd0YndJ?=
 =?utf-8?B?MkdjWVdwT2lTTG1meTh2NUsxTUcwQTJURTAxVm1zeHgzMVNWNFRHdUs2azhN?=
 =?utf-8?B?dzdyalc4L0xqN092R05JcnFTeC96Q1c1R3JXMTZRMzRFM2dWekd2R1g3bGZr?=
 =?utf-8?B?TVlhRUNWRlkxdkJCRnI3UEMvU1NYM091V3hLcGlxTDhqV0lpYzM4L3JzNUkw?=
 =?utf-8?B?N0hENmZSREp3M0s5ZWZkb0dnc1NhOHdMUmh2SzlLVnFZaEFlMkp5U1NiNTNl?=
 =?utf-8?B?d0x0ZmNDL1ZxVWJxRDNsRTlyWnEwQklEVitPbHJlMFRrcVdNWG1ZRytXVVpG?=
 =?utf-8?B?RXVCcXBSRnpOb0hHbmp2dSs5VXFGbnJjb0kzOXlQS1NIRUR0YjM2elpiQllm?=
 =?utf-8?B?ZDdSTGd3YS9YQUFRUUljT2lvcm80bi9oMEQ0ck1hT3lEd2pFL3NERFN1N2RN?=
 =?utf-8?B?VTNjdFkxWGZITjZ2cEZsSis4aFlOTkExRXk3WU40SWhqU1N2L2U3d1dZajBn?=
 =?utf-8?B?WFpuU2tNUWhTZWNGeC8vTFFPakNGMk1hc0Juc0JxSEJjL0t0YzhiYXc3cDBl?=
 =?utf-8?B?U2lRL3NUc09EZ2plSVErVFhsK3d0TGdOOFljRk5uZjNER3QwM0hiL3oraENZ?=
 =?utf-8?B?YmtFUWpCbEtSTWNianFDRkNYRkVvSWdCakZjYklTejJ6Z2w3Mjh4QjlmSVFV?=
 =?utf-8?B?eHJaOWZIMXBvZWJ1S3ZLcjNlRW1RdVVvdE93QWpBUjNPMFZ0Z2NrR0pKMkpG?=
 =?utf-8?B?UWxHOHA2RXp1WW9IUW00d1lnaUIyNEtuQURTc1djaU9YeHBHa3RNK0Y4Q2ZY?=
 =?utf-8?B?dlBQTHBoNW9LaStpREY2eHY3QVk2d1RaWUpMd0RhQ3lQcVFpWTMrRkd3Z3NH?=
 =?utf-8?B?OFNETERVVGdoTENnRnpETGlpalZmd2JFcXFpV1FkUXI1ZlN3Qm13eXhTUlVH?=
 =?utf-8?B?M1Fsb01hUHBlVWxIYTUrV1R0eDJLcDhOeFhLcUI5Q3A4VjlhMW5CVkdyRHB6?=
 =?utf-8?B?NHNaQlB3aFZMWTAzNS80ZWQ2VjlMbGdxdStnZEdmMU1QOGtkdmxHVVhwNWMv?=
 =?utf-8?B?NVFUbGZ4V2d3YzNaYnZ2V1R2YksxZUp0QmxVcUdRaGUvUXJURkxzVEVMK1Bz?=
 =?utf-8?B?T1RTSzc5bDJQQXVXS1VvSk10WDd4ZHpQWUxXMmZDbDJlQmFoZ3p0U2xsL0RR?=
 =?utf-8?Q?MqDOuY9097B5aGpuVV8l?=
X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1308;6:1o+TaO5Do1sYAyumX1ETYFIBbR0vQBWHtWVkniej+NeDUQpGzdgOfR6odJwwI0NxDRFa+Gj19ebfaECHyDozih9xHLd34NTtfSWHRLaDpSZTiOodcTZ7S3XF5NcsfR9vNUgyfhyd/XngaoF+UObhsb6Ws3SouNkj9oqwoHIU3YErISWFEm2lCn7dUuzpGZkAW/sJT4NKlPLYtZN9jzlneJSuWtZVGNvBNpmqLDub7i3vWWQzyMXAGFJpocWoyVNdgCm4SZQzY/L9BSnK3QaNdmVPzOWDes1idtq410WHMJWi+xkko8OjKrqmPcOP8vNtv4QsiuuRbZakmdUuQSqqew==;5:o0yIZ5pFa0PiVTFW+a7KCXa0qOkMlIcQqRh4xML68lRia+KnwFKVzYODuXA8awH92C+EoTB/l8qqhvmTCML3EDQDrbuHV46LVJZXCUw/xIkuK24TUnzPaOKMotmIyEMXGJzfC8Nj+iTq3F8wGd2yYQ==;24:A1XUtz93HvsRm1KD3175o2pp5EBgqVAT5vqOP6gknelAWus73Qq7XBKUVTtjJQqLFfkfWUVOBATqvZF9fLiEyOlFJVsO71rQQ6+1RxA32fo=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1308;7:NUX+px7yttcczDMUnhYSziKxYllUw0fNHfFLmUutXZff8wWbSRtQZzhHn91800btdxwbqCRPcRwdKyRq0kA4OMGdbYq0T+z4B8uJ9hDrovxbWY4CXkbcuvllZ/zKgqyIye4vLQnkNVzSW55+6oTjjYAASvpUhto9ZgL7dSek90U+VPsBU9fMAskj1pwCEK/TjtjlTrIpIQMPT+LOdsGzajjS1yMDiyLfg+YIDJ+xgm3hOXoNT41UKibdhg0eoqCX+zZtitOM+/oSLUovKrzMHz5eUkVwpK1TNihLj6u1DsGe+LbVKeQggi+wW7Sy1B5lInRhmPJy5dIZI7O8qDuR1x5Yu/Q+Td6LiNiQY+RP1D8=;20:HGk66C2rqLG0wFiFY8ow/nTo5FsnMoXFcrL9W2Hw1y0cRTTDxKBGEnTFi7WGOtUmdnk9tlicp++0xnrB87kKixbRHESkfLO4CoF6W3MsS3cPPkCXEDbmaVxFlhRx+cBqPsw7Bg8fK8OFa7TUmNgo88ZtVSgCNoySq20eD7DZK8Hsiy6UM/SY+OKiMBaOauMUYQuOWLFOZwDtxBjRr/jHKkuYOlqnwyVCdrdW9BdOFcxB5kHzJURMlpFuncB9tAST
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2016 12:11:47.6439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1308
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 394
Lines: 12

Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> +typedef char drm_format_name_buf[32];

Please don't use a typedef for this, just define the maximum size of 
characters the function might write somewhere.

See the kernel coding style as well:
> In general, a pointer, or a struct that has elements that can reasonably
> be directly accessed should **never** be a typedef.

Regards,
Christian.