Date: Sat, 5 Nov 2016 16:38:44 +0000
From: Eric Engestrom <eric@engestrom.ch>
To: Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>
Cc: linux-kernel@vger.kernel.org,
        Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Xinliang Liu <z.liuxinliang@hisilicon.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Sinclair Yeh <syeh@vmware.com>,
        Thomas Hellstrom <thellstrom@vmware.com>,
        Tom St Denis <tom.stdenis@amd.com>,
        Michel =?utf-8?Q?D=C3=A4nzer?= <michel.daenzer@amd.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Emily Deng <Emily.Deng@amd.com>, Chunming Zhou <David1.Zhou@amd.com>,
        Flora Cui <Flora.Cui@amd.com>, Vitaly Prosyak <vitaly.prosyak@amd.com>,
        Ken Wang <Qingqing.Wang@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        Alexandre Demers <alexandre.f.demers@gmail.com>,
        Junwei Zhang <Jerry.Zhang@amd.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name()
Message-ID: <20161105163844.GA29546@engestrom.ch>
References: <20161105012344.GA28349@engestrom.ch>
 <20161105013325.3889-1-eric@engestrom.ch>
 <cc7acbea-a721-22b4-67d3-22198decced6@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cc7acbea-a721-22b4-67d3-22198decced6@amd.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 21

On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote:
> Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> > +typedef char drm_format_name_buf[32];
> 
> Please don't use a typedef for this, just define the maximum size of
> characters the function might write somewhere.
> 
> See the kernel coding style as well:
> > In general, a pointer, or a struct that has elements that can reasonably
> > be directly accessed should **never** be a typedef.
> 

I would normally agree as I tend to hate typedefs ($DAYJOB {ab,mis}uses
them way too much), and your way was what I wrote at first, but Rob Clark's
typedef idea makes it much harder for someone to allocate a buffer of
the wrong size, which IMO is good thing here.

I can rewrite the typedef out if you think it's better.

Cheers,
  Eric