Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756830AbcKETkY (ORCPT ); Sat, 5 Nov 2016 15:40:24 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:33353 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756576AbcKETkW (ORCPT ); Sat, 5 Nov 2016 15:40:22 -0400 Date: Sat, 5 Nov 2016 15:40:19 -0400 From: Konrad Rzeszutek Wilk To: Geert Uytterhoeven Cc: Konrad Rzeszutek Wilk , Jonathan Corbet , Magnus Damm , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux-foundation.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/2] swiotlb: Rate-limit printing when running out of SW-IOMMU space Message-ID: <20161105194018.GB26349@localhost.localdomain> References: <1477928704-10611-1-git-send-email-geert+renesas@glider.be> <1477928704-10611-2-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477928704-10611-2-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 34 On Mon, Oct 31, 2016 at 04:45:03PM +0100, Geert Uytterhoeven wrote: > If the system runs out of SW-IOMMU space, changes are high successive > requests will fail, too, flooding the kernel log. This is true > especially for streaming DMA, which is typically used repeatedly outside > the driver's initialization routine. Add rate-limiting to fix this. > > While at it, get rid of the open-coded dev_name() handling by using the > appropriate dev_err_*() variant. > > Signed-off-by: Geert Uytterhoeven applied. > --- > lib/swiotlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/swiotlb.c b/lib/swiotlb.c > index 22e13a0e19d76a2b..6ce764410ae475cc 100644 > --- a/lib/swiotlb.c > +++ b/lib/swiotlb.c > @@ -714,8 +714,8 @@ void swiotlb_tbl_sync_single(struct device *hwdev, phys_addr_t tlb_addr, > * When the mapping is small enough return a static buffer to limit > * the damage, or panic when the transfer is too big. > */ > - printk(KERN_ERR "DMA: Out of SW-IOMMU space for %zu bytes at " > - "device %s\n", size, dev ? dev_name(dev) : "?"); > + dev_err_ratelimited(dev, "DMA: Out of SW-IOMMU space for %zu bytes\n", > + size); > > if (size <= io_tlb_overflow || !do_panic) > return; > -- > 1.9.1 >