Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750999AbcKEVaZ (ORCPT ); Sat, 5 Nov 2016 17:30:25 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35954 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcKEVaW (ORCPT ); Sat, 5 Nov 2016 17:30:22 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161104093050.GB1839@veci.piliscsaba.szeredi.hu> From: Linus Torvalds Date: Sat, 5 Nov 2016 14:30:21 -0700 X-Google-Sender-Auth: KlGesL32Ll8IULsL3A3Cw47E8CI Message-ID: Subject: Re: [GIT PULL] overlayfs fixes for 4.9-rc3 To: Miklos Szeredi Cc: Amir Goldstein , Linux Kernel Mailing List , linux-fsdevel , "linux-unionfs@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 31 On Sat, Nov 5, 2016 at 12:45 PM, Miklos Szeredi wrote: > > The feature that would be introduced is this: allow directory renames > to work without having to recursively copy-up the subtree. Whatever > mechanism is devised to do this will be backward incompatible. Maybe > it's a misguided idea, but it's been through several rounds of reviews > on the relevant mailing lists and there weren't any objections (yet). > > And the thing is, backward incompatibility is less of an issue for > overlayfs than for normal filesystems, because it's usually not > something people store their root filesystems on, and if so they can > simply not turn off this feature. (a) that should be explained (b) that has nothing to do with being marked for stable (c) that new doesn't actually explain in any way why you'd want "feature flags" thing, for exactly the same "backwards incompatibility is less of an issue" reason that you state. Why not "just do it", in other words. For exactly the reasons you say. Make it a mount option that people can choose to use or not. > overlayfs relies on xattr to create opaque directories Yes and no. It relies on it for THAT ONE FEATURE, which you don't have to use. As far as I can tell, overlayfs does *not* rely on xattrs in general. Linus