Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751171AbcKEW0m (ORCPT ); Sat, 5 Nov 2016 18:26:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:41337 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbcKEW0k (ORCPT ); Sat, 5 Nov 2016 18:26:40 -0400 Date: Sat, 5 Nov 2016 23:26:37 +0100 From: Jan Kara To: Jens Axboe Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, jack@suse.cz, hch@lst.de Subject: Re: [PATCH 3/8] writeback: mark background writeback as such Message-ID: <20161105222637.GC32353@quack2.suse.cz> References: <1478034531-28559-1-git-send-email-axboe@fb.com> <1478034531-28559-4-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478034531-28559-4-git-send-email-axboe@fb.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 35 On Tue 01-11-16 15:08:46, Jens Axboe wrote: > If we're doing background type writes, then use the appropriate > background write flags for that. > > Signed-off-by: Jens Axboe Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > include/linux/writeback.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 50c96ee8108f..c78f9f0920b5 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -107,6 +107,8 @@ static inline int wbc_to_write_flags(struct writeback_control *wbc) > { > if (wbc->sync_mode == WB_SYNC_ALL) > return REQ_SYNC; > + else if (wbc->for_kupdate || wbc->for_background) > + return REQ_BACKGROUND; > > return 0; > } > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR