Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbcKFS6I (ORCPT ); Sun, 6 Nov 2016 13:58:08 -0500 Received: from up.free-electrons.com ([163.172.77.33]:60968 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751221AbcKFS5R (ORCPT ); Sun, 6 Nov 2016 13:57:17 -0500 Date: Sun, 6 Nov 2016 19:57:15 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Mark Rutland , Linux-ALSA , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi Subject: Re: [PATCH v2 06/14] ASoC: sun4i-codec: Add support for A31 playback through headphone output Message-ID: <20161106185715.tlvcakzqay2lamd5@lukather> References: <20161103075556.29018-1-wens@csie.org> <20161103075556.29018-7-wens@csie.org> <20161103173602.zchyciwj66zdibc7@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hupmdhuzwb6qkxbg" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2402 Lines: 69 --hupmdhuzwb6qkxbg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 04, 2016 at 09:08:11AM +0800, Chen-Yu Tsai wrote: > On Fri, Nov 4, 2016 at 1:36 AM, Maxime Ripard > wrote: > > Hi, > > > > On Thu, Nov 03, 2016 at 03:55:48PM +0800, Chen-Yu Tsai wrote: > >> +/* headphone controls */ > >> +static const char * const sun6i_codec_hp_src_enum_text[] =3D { > >> + "DAC", "Mixer", > >> +}; > >> + > >> +static SOC_ENUM_DOUBLE_DECL(sun6i_codec_hp_src_enum, > >> + SUN6I_CODEC_OM_DACA_CTRL, > >> + SUN6I_CODEC_OM_DACA_CTRL_LHPIS, > >> + SUN6I_CODEC_OM_DACA_CTRL_RHPIS, > >> + sun6i_codec_hp_src_enum_text); > >> + > >> +static const struct snd_kcontrol_new sun6i_codec_hp_src[] =3D { > >> + SOC_DAPM_ENUM("Headphone Source Playback Route", > >> + sun6i_codec_hp_src_enum), > >> +}; > > > > What is that route exactly? A muxer? >=20 > Yup. The following is part of the widgets list later in the code: >=20 > + /* Headphone output path */ > + SND_SOC_DAPM_MUX("Headphone Source Playback Route", > + SND_SOC_NOPM, 0, 0, sun6i_codec_hp_src), Oh, right. You can add my Acked-by on this one and the other patches too. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --hupmdhuzwb6qkxbg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYH30LAAoJEBx+YmzsjxAg5X8QAKolrD4LUVRqLRMpSYP5BXpf Pbvz2RZi2eAgxsZYjipiIxKbOrh3lsPDlZH7fwqhIkq1VXl9TCyGwAKq3doyr7Wl Vj/3pERsaubfW+6vidSVmWvbB0HHWNVKXwHfyQnxPnmX21uRVlT+BBRtKdUYii/h R2BEMkUYXGEfHNMW2xr9tEgom28EGdjlSa1PNrHKAFR7Ho93XeI9AoLvuOjcw3vi E6jmyZc+nbtsLYZrD+dudJf5NmgUHttnaayJAnJ3YwDk+B2Y/f+hEWIYSpfQImvS ddinSpExOmnK6ads3ZGQQ7YBYNKIbYRUE89fGRScUTMZotxYmU2Y7BdqvGuvKmpJ R+6lLdw6BrZD2zF2hL4ng+ig4RF+e+FP/GOkvUum3LKQOUL1O72EdmBTQn9zrmbt liCN1FQQ48LdoUoYmZn6uxClvKGne20v589939c6vXzzs6vQC2ZbERaMnmwAyy8R 8HZOjYSvg8exj3e9LpOBf5kQsZNLQVNnMclgG1/v7KnJ5SOUSd6fSKfShXX/hUIS 5yKYWrb+vaPqYWUIK/8spgz/EVn4/1WdZu5Ct04D8RLIFjVcGPHdYTEoyeQS1XmM zftK8qHJorcbEYQwGZsShi25ytvUQA9gQepqcD4rGYqRhftT93kyLDJYbY/AvtHM padejtnE9czbF58QhFee =Giga -----END PGP SIGNATURE----- --hupmdhuzwb6qkxbg--