Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbcKGBzw (ORCPT ); Sun, 6 Nov 2016 20:55:52 -0500 Received: from casper.infradead.org ([85.118.1.10]:56674 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbcKGBzq (ORCPT ); Sun, 6 Nov 2016 20:55:46 -0500 Date: Mon, 7 Nov 2016 01:55:44 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List , Bobi Jam Subject: Re: [PATCH 10/14] staging/lustre/llite: protect from accessing NULL lli_clob In-Reply-To: <1478136304-867780-11-git-send-email-green@linuxhacker.ru> Message-ID: References: <1478136304-867780-1-git-send-email-green@linuxhacker.ru> <1478136304-867780-11-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161107_015544_142693_B9957819 X-CRM114-Status: GOOD ( 11.14 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 41 > From: Bobi Jam > > Need to check file's lli_clob object before calling > lov_read_and_clear_async_rc(). Reviewed-by: James Simmons > Signed-off-by: Bobi Jam > Reviewed-by: Jinshan Xiong > Reviewed-by: Oleg Drokin > Reviewed-on: http://review.whamcloud.com/23031 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8682 > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/llite/file.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c > index c1c7551..7886840 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -2328,9 +2328,11 @@ int ll_fsync(struct file *file, loff_t start, loff_t end, int datasync) > lli->lli_async_rc = 0; > if (rc == 0) > rc = err; > - err = lov_read_and_clear_async_rc(lli->lli_clob); > - if (rc == 0) > - rc = err; > + if (lli->lli_clob) { > + err = lov_read_and_clear_async_rc(lli->lli_clob); > + if (rc == 0) > + rc = err; > + } > } > > err = md_sync(ll_i2sbi(inode)->ll_md_exp, ll_inode2fid(inode), &req); > -- > 2.7.4 > >