Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbcKGB5L (ORCPT ); Sun, 6 Nov 2016 20:57:11 -0500 Received: from casper.infradead.org ([85.118.1.10]:56792 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbcKGB5A (ORCPT ); Sun, 6 Nov 2016 20:57:00 -0500 Date: Mon, 7 Nov 2016 01:56:56 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List , Jinshan Xiong Subject: Re: [PATCH 13/14] staging/lustre/llite: do not clear uptodate bit in page delete In-Reply-To: <1478136304-867780-14-git-send-email-green@linuxhacker.ru> Message-ID: References: <1478136304-867780-1-git-send-email-green@linuxhacker.ru> <1478136304-867780-14-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161107_015656_999996_E64136F0 X-CRM114-Status: GOOD ( 13.41 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 51 > From: Jinshan Xiong > > Otherwise, if the race between page fault and truncate occurs, it > will cause the page fault routine to return an EIO error. > > In filemap_fault() { > page_not_uptodate: > ... > ClearPageError(page); > error = mapping->a_ops->readpage(file, page); > if (!error) { > wait_on_page_locked(page); > if (!PageUptodate(page)) > error = -EIO; > } > ... > } > > However, I tend to think this is a defect in kernel implementation, > because it assumes PageUptodate shouldn't be cleared but file read > routine doesn't make the same assumption. Reviewed-by: James Simmons > Signed-off-by: Jinshan Xiong > Reviewed-on: http://review.whamcloud.com/22827 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8633 > Reviewed-by: Li Dongyang > Reviewed-by: Bobi Jam > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/llite/vvp_page.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/llite/vvp_page.c b/drivers/staging/lustre/lustre/llite/vvp_page.c > index 25490a5..23d6630 100644 > --- a/drivers/staging/lustre/lustre/llite/vvp_page.c > +++ b/drivers/staging/lustre/lustre/llite/vvp_page.c > @@ -166,7 +166,6 @@ static void vvp_page_delete(const struct lu_env *env, > refc = atomic_dec_return(&page->cp_ref); > LASSERTF(refc >= 1, "page = %p, refc = %d\n", page, refc); > > - ClearPageUptodate(vmpage); > ClearPagePrivate(vmpage); > vmpage->private = 0; > /* > -- > 2.7.4 > >