Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbcKGB5b (ORCPT ); Sun, 6 Nov 2016 20:57:31 -0500 Received: from casper.infradead.org ([85.118.1.10]:56814 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbcKGB5X (ORCPT ); Sun, 6 Nov 2016 20:57:23 -0500 Date: Mon, 7 Nov 2016 01:57:21 +0000 (GMT) From: James Simmons To: Oleg Drokin cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List , Patrick Farrell Subject: Re: [PATCH 09/14] staging/lustre/ptlrpc: Suppress error for flock requests In-Reply-To: <1478136304-867780-10-git-send-email-green@linuxhacker.ru> Message-ID: References: <1478136304-867780-1-git-send-email-green@linuxhacker.ru> <1478136304-867780-10-git-send-email-green@linuxhacker.ru> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161107_015721_625730_379133E6 X-CRM114-Status: GOOD ( 13.62 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 39 > From: Patrick Farrell > > -EAGAIN is a normal return when requesting POSIX flocks. > We can't recognize exactly that case here, but it's the > only case that should result in -EAGAIN on LDLM_ENQUEUE, so > don't print to console in that case. Reviewed-by: James Simmons > Signed-off-by: Patrick Farrell > Reviewed-on: http://review.whamcloud.com/22856 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8658 > Reviewed-by: Andreas Dilger > Reviewed-by: Bob Glossman > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/ptlrpc/client.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c > index 7cbfb4c..bb7ae4e 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/client.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c > @@ -1191,7 +1191,9 @@ static int ptlrpc_check_status(struct ptlrpc_request *req) > lnet_nid_t nid = imp->imp_connection->c_peer.nid; > __u32 opc = lustre_msg_get_opc(req->rq_reqmsg); > > - if (ptlrpc_console_allow(req)) > + /* -EAGAIN is normal when using POSIX flocks */ > + if (ptlrpc_console_allow(req) && > + !(opc == LDLM_ENQUEUE && err == -EAGAIN)) > LCONSOLE_ERROR_MSG(0x011, "%s: operation %s to node %s failed: rc = %d\n", > imp->imp_obd->obd_name, > ll_opcode2str(opc), > -- > 2.7.4 > >