Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbcKGCBV (ORCPT ); Sun, 6 Nov 2016 21:01:21 -0500 Received: from casper.infradead.org ([85.118.1.10]:56962 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcKGCBO (ORCPT ); Sun, 6 Nov 2016 21:01:14 -0500 Date: Mon, 7 Nov 2016 02:01:11 +0000 (GMT) From: James Simmons To: Andrew Kanner cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, bevans@cray.com, bhaktipriya96@gmail.com, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: lustre: fixed shadowed variable in socklnd_cb.c In-Reply-To: <1478213386-13853-1-git-send-email-andrew.kanner@gmail.com> Message-ID: References: <1478213386-13853-1-git-send-email-andrew.kanner@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161107_020111_072058_C23C1D39 X-CRM114-Status: GOOD ( 11.28 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 32 > Removed redundant declaration of variable 'tx' in local scope > Fixed: sparse warning: > socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one > socklnd_cb.c:2435:25: originally declared here Reviewed-by: James Simmons > Signed-off-by: Andrew Kanner > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > index c1c6f60..f31f4a1 100644 > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c > @@ -2473,8 +2473,8 @@ ksocknal_check_peer_timeouts(int idx) > * holding only shared lock > */ > if (!list_empty(&peer->ksnp_tx_queue)) { > - struct ksock_tx *tx = list_entry(peer->ksnp_tx_queue.next, > - struct ksock_tx, tx_list); > + tx = list_entry(peer->ksnp_tx_queue.next, > + struct ksock_tx, tx_list); > > if (cfs_time_aftereq(cfs_time_current(), > tx->tx_deadline)) { > -- > 2.1.4 > >