Message-ID: <1478486861.13362.2.camel@perches.com>
Subject: Re: [PATCH] staging: lustre: o2iblnd: replace space indentation
 with tabs
From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>,
        Nicholas Hanley <nicholasjhanley@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
        gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Sun, 06 Nov 2016 18:47:41 -0800
In-Reply-To: <alpine.LFD.2.20.1611070202090.21293@casper.infradead.org>
References: <20161105000256.11714-1-nicholasjhanley@gmail.com>
         <alpine.LFD.2.20.1611070202090.21293@casper.infradead.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 625
Lines: 14

On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> Reviewed-by: James Simmons <jsimmons@infradead.org>
[]
> > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> >  {
> >  	__u64 *pages = tx->tx_pages;
> >  	bool is_rx = (rd != tx->tx_rd);
> > -        bool tx_pages_mapped = 0;
> > +	bool tx_pages_mapped = 0;

It's generally better to use bool assignments to true/false not 1/0.