Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcKGDzk (ORCPT ); Sun, 6 Nov 2016 22:55:40 -0500 Received: from casper.infradead.org ([85.118.1.10]:58832 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbcKGDzj (ORCPT ); Sun, 6 Nov 2016 22:55:39 -0500 Date: Mon, 7 Nov 2016 03:55:36 +0000 (GMT) From: James Simmons To: Joe Perches cc: Nicholas Hanley , oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs In-Reply-To: <1478486861.13362.2.camel@perches.com> Message-ID: References: <20161105000256.11714-1-nicholasjhanley@gmail.com> <1478486861.13362.2.camel@perches.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161107_035536_552510_E6399803 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 18 > On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote: > > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd. > > Reviewed-by: James Simmons > [] > > > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c > [] > > > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx, > > > { > > > __u64 *pages = tx->tx_pages; > > > bool is_rx = (rd != tx->tx_rd); > > > - bool tx_pages_mapped = 0; > > > + bool tx_pages_mapped = 0; > > It's generally better to use bool assignments to true/false not 1/0. Nicholas can you resubmit with tx_pages_mapped = false. Looking at the lustre code its the only place like this. Thanks for pointing this out.