Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbcKGEf7 (ORCPT ); Sun, 6 Nov 2016 23:35:59 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36667 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbcKGEf6 (ORCPT ); Sun, 6 Nov 2016 23:35:58 -0500 Date: Mon, 7 Nov 2016 10:05:54 +0530 From: Viresh Kumar To: Markus Mayer Cc: "Rafael J . Wysocki" , Power Management List , Broadcom Kernel List , Linux Kernel Mailing List , Markus Mayer Subject: Re: [PATCH v2 1/2] cpufreq: add new attribute type cpufreq_freq_attr_wr_perm() Message-ID: <20161107043554.GB21030@vireshk-i7> References: <20161104165536.20088-1-code@mmayer.net> <20161104165536.20088-2-code@mmayer.net> <20161107043348.GA21030@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161107043348.GA21030@vireshk-i7> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 31 On 07-11-16, 10:03, Viresh Kumar wrote: > On 04-11-16, 09:55, Markus Mayer wrote: > > From: Markus Mayer > > > > With the new attribute type, it is possible to create write-only > > CPUfreq attributes. > > > > Signed-off-by: Markus Mayer > > --- > > include/linux/cpufreq.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > > index 5fa55fc..ed09930 100644 > > --- a/include/linux/cpufreq.h > > +++ b/include/linux/cpufreq.h > > @@ -234,6 +234,10 @@ __ATTR(_name, _perm, show_##_name, NULL) > > static struct freq_attr _name = \ > > __ATTR(_name, 0644, show_##_name, store_##_name) > > > > +#define cpufreq_freq_attr_wr_perm(_name, _perm) \ > > shouldn't this be _wo_perm ? > > Also, I wouldn't mind doing this in the second patch itself. Also there is no need to define a _perm variant here, and then you can avoid sending 0200 as argument as well. -- viresh