Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbcKGHDa (ORCPT ); Mon, 7 Nov 2016 02:03:30 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59774 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752038AbcKGHD3 (ORCPT ); Mon, 7 Nov 2016 02:03:29 -0500 Date: Mon, 7 Nov 2016 08:03:22 +0100 From: Heiko Carstens To: Masahiro Yamada Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, Sascha Silbe , Christian Borntraeger , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c References: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> <1478403928-20799-2-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478403928-20799-2-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110707-0040-0000-0000-000002545340 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110707-0041-0000-0000-00002274005E Message-Id: <20161107070322.GA4075@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-07_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611070133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 22 On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > We generally expect headers in arch/$(ARCH)/include/asm directory > are included from kernel sources, but facilities_src.h is not; > it is included from the arch/s390/tools/gen_facilities.c tool. > > There is no reason to expose this header to the public include path. > Furthermore, facilities_src.h makes sure to be included only from > gen_facilities.c by the following: > > #ifndef S390_GEN_FACILITIES_C > #error "This file can only be included by gen_facilities.c" > #endif > > This check can be removed by merging the two files. > > Signed-off-by: Masahiro Yamada > --- Both patches: Acked-by: Heiko Carstens Martin, can you please pick them up?