Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcKGIGC convert rfc822-to-8bit (ORCPT ); Mon, 7 Nov 2016 03:06:02 -0500 Received: from ozlabs.org ([103.22.144.67]:41971 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcKGIFn (ORCPT ); Mon, 7 Nov 2016 03:05:43 -0500 From: Michael Ellerman To: Joe Perches , David Miller , madalin.bucur@nxp.com, Andrew Morton , Jonathan Corbet Cc: pebolle@tiscali.nl, joakim.tjernlund@transmode.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ppc@mindchasers.com, oss@buserror.net, linuxppc-dev@lists.ozlabs.org Subject: Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) In-Reply-To: <1478242438.1924.31.camel@perches.com> References: <1478117854-8952-1-git-send-email-madalin.bucur@nxp.com> <1478117854-8952-3-git-send-email-madalin.bucur@nxp.com> <20161103.155816.642712588084106823.davem@davemloft.net> <1478242438.1924.31.camel@perches.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 07 Nov 2016 19:05:40 +1100 Message-ID: <877f8fn297.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 Joe Perches writes: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >> > This introduces the Freescale Data Path Acceleration Architecture >> > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) >> > +{ >> > +     u8 i; >> > +     size_t res = DPAA_BP_RAW_SIZE / 2; >> >> Always order local variable declarations from longest to shortest line, >> also know as Reverse Christmas Tree Format. > > I think this declaration sorting order is misguided but > here's a possible change to checkpatch adding a test for it > that does this test just for net/ and drivers/net/ And arch/powerpc too please. cheers