Subject: Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII
 definitions
To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= <mans@mansr.com>
References: <581CD1AF.6030300@laposte.net> <581CD210.5060206@laposte.net>
 <yw1xoa1uhylu.fsf@unicorn.mansr.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Mason <slash.tmp@free.fr>, Andrew Lunn <andrew@lunn.ch>
From: Sebastian Frias <sf84@laposte.net>
Message-ID: <58205103.4090208@laposte.net>
Date: Mon, 7 Nov 2016 11:01:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <yw1xoa1uhylu.fsf@unicorn.mansr.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 700
Lines: 23

Hi M?ns,

On 11/05/2016 01:58 PM, M?ns Rullg?rd wrote:
>>  	if (gigabit) {
>> -		if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
>> +		if (phy_interface_is_rgmii(phydev))
>>  			mac_mode |= RGMII_MODE;
>>
>>  		mac_mode |= GMAC_MODE;
> 
> As I said before, this part can/should be applied separately, although
> personally I probably wouldn't have bothered adding a single-use variable.

It was for consistency with other functions that use 'phydev', but I don't
mind making the changes.

Just to be clear, when you say "can/should be applied separately", do you
mean that this patch should not be part of a series, and that I should split
the series into separate patches?

Best regards,

Sebastian