Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbcKGLaN (ORCPT ); Mon, 7 Nov 2016 06:30:13 -0500 Received: from mail.sig21.net ([80.244.240.74]:41195 "EHLO mail.sig21.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752768AbcKGLaK (ORCPT ); Mon, 7 Nov 2016 06:30:10 -0500 Date: Mon, 7 Nov 2016 12:29:47 +0100 From: Johannes Stezenbach To: VDR User Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Andy Lutomirski , Jiri Kosina , Patrick Boettcher , Linux Kernel Mailing List , Andy Lutomirski , Michael Krufky , Mauro Carvalho Chehab , =?iso-8859-1?Q?J=F6rg?= Otte Subject: Re: [PATCH v2 18/31] gp8psk: don't do DMA on stack Message-ID: <20161107112947.qlxpzhxi5k3w7ajz@linuxtv.org> References: <632081ba085ddf0ded63cce3dbcf3870485d3cd3.1476179975.git.mchehab@s-opensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) X-Spam-21-Score: -2.9 (--) X-Spam-21-Report: No, score=-2.9 required=8.0 tests=ALL_TRUSTED=-1,BAYES_00=-1.9,KHOP_BIG_TO_CC=0.001,T_HEADER_FROM_DIFFERENT_DOMAINS=0.01 autolearn=ham autolearn_force=no Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 39 On Sun, Nov 06, 2016 at 11:51:14AM -0800, VDR User wrote: > I applied this patch to the 4.8.4 kernel driver (that I'm currently > running) and it caused nothing but "frontend 0/0 timed out while > tuning". Is there another patch that should be used in conjunction > with this? If not, this patch breaks the gp8psk driver. > > Thanks. Thanks for testing. "If it's not tested it's broken"... > On Tue, Oct 11, 2016 at 3:09 AM, Mauro Carvalho Chehab > wrote: > > index 5d0384dd45b5..fa215ad37f7b 100644 > > --- a/drivers/media/usb/dvb-usb/gp8psk.c > > +++ b/drivers/media/usb/dvb-usb/gp8psk.c > > int gp8psk_usb_in_op(struct dvb_usb_device *d, u8 req, u16 value, u16 index, u8 *b, int blen) > > { > > + struct gp8psk_state *st = d->priv; > > int ret = 0,try = 0; > > > > if ((ret = mutex_lock_interruptible(&d->usb_mutex))) > > return ret; > > > > while (ret >= 0 && ret != blen && try < 3) { > > + memcpy(st->data, b, blen); > > ret = usb_control_msg(d->udev, > > usb_rcvctrlpipe(d->udev,0), > > req, > > USB_TYPE_VENDOR | USB_DIR_IN, > > - value,index,b,blen, > > + value, index, st->data, blen, > > 2000); I guess for usb_in the memcpy should be after the usb_control_msg and from st->data to b. Johannes