From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org, benh@kernel.crashing.org,
        paulus@samba.org, mpe@ellerman.id.au,
        "Kirill A . Shutemov" <kirill@shutemov.name>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw
In-Reply-To: <201611071732.njM40txT%fengguang.wu@intel.com>
References: <201611071732.njM40txT%fengguang.wu@intel.com>
Date: Mon, 07 Nov 2016 17:09:36 +0530
MIME-Version: 1.0
Content-Type: text/plain
Message-Id: <8737j3h62v.fsf@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1794
Lines: 46

kbuild test robot <lkp@intel.com> writes:

> Hi Aneesh,
>
> [auto build test ERROR on mmotm/master]
> [also build test ERROR on v4.9-rc4 next-20161028]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/mm-move-vma_is_anonymous-check-within-pmd_move_must_withdraw/20161107-164033
> base:   git://git.cmpxchg.org/linux-mmotm.git master
> config: i386-randconfig-x006-201645 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All error/warnings (new ones prefixed by >>):
>
>    mm/huge_memory.c: In function 'pmd_move_must_withdraw':
>>> mm/huge_memory.c:1441:58: error: 'vma' undeclared (first use in this function)
>      return (new_pmd_ptl != old_pmd_ptl) && vma_is_anonymous(vma);
>                                                              ^~~
>    mm/huge_memory.c:1441:58: note: each undeclared identifier is reported only once for each function it appears in
>>> mm/huge_memory.c:1442:1: warning: control reaches end of non-void function [-Wreturn-type]
>     }
>     ^
>
> vim +/vma +1441 mm/huge_memory.c
>
>   1435		/*
>   1436		 * With split pmd lock we also need to move preallocated
>   1437		 * PTE page table if new_pmd is on different PMD page table.
>   1438		 *
>   1439		 * We also don't deposit and withdraw tables for file pages.
>   1440		 */
>> 1441		return (new_pmd_ptl != old_pmd_ptl) && vma_is_anonymous(vma);
>> 1442	}
>   1443	#endif
>   1444	
>   1445	bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr,
>

My bad, I didn't test with hugepage enabled for x86. Will fixup in the
next update.

-aneesh